Skip to content

Commit d467311

Browse files
Copilotswissspidy
andauthored
Hoist ArrayAccess check out of recursion loop
Agent-Logs-Url: https://github.com/wp-cli/search-replace-command/sessions/465c889c-defb-4d7e-994e-41876a460be2 Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
1 parent 8f23a25 commit d467311

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/WP_CLI/SearchReplacer.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,9 +195,10 @@ private function run_recursively( $data, $serialised, $recursion_level = 0, $vis
195195
);
196196
} else {
197197
try {
198+
$is_array_access = $data instanceof \ArrayAccess;
198199
foreach ( $data as $key => $value ) {
199200
$value = $this->run_recursively( $value, false, $recursion_level + 1, $visited_data );
200-
if ( $data instanceof \ArrayAccess ) {
201+
if ( $is_array_access ) {
201202
$data[ $key ] = $value;
202203
} else {
203204
$data->$key = $value;

0 commit comments

Comments
 (0)