Fix phar_safe_path by using Phar::running(false) for WP_CLI_PHAR_PATH

Keep WP_CLI_ROOT using the hardcoded alias 'phar://wp-cli.phar' to ensure template paths resolve correctly. Only change WP_CLI_PHAR_PATH to use Phar::running(false) which returns the filesystem path without phar:// protocol, preventing phar_safe_path() from creating malformed paths.

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>

Author: Copilot

php/boot-phar.php

@@ -9,22 +9,18 @@
 	die( -1 );
 }
 
-// Store the phar stream path for use in determining WP_CLI_ROOT.
-// Using Phar::running(true) returns the phar:// stream wrapper path (e.g., phar:///path/to/file.phar)
-// which ensures consistent path resolution when the phar is renamed.
-$wp_cli_phar_path = Phar::running( true );
-
 // Store the filesystem path for `Utils\phar_safe_path()` function.
 // Using Phar::running(false) returns just the filesystem path without phar:// protocol.
+// This prevents phar_safe_path() from attempting to replace "phar://phar://..." incorrectly.
 define( 'WP_CLI_PHAR_PATH', Phar::running( false ) );
 
-// Determine WP_CLI_ROOT dynamically based on the actual phar stream path
-// instead of hardcoding 'phar://wp-cli.phar' to handle renamed phars.
-if ( file_exists( $wp_cli_phar_path . '/php/wp-cli.php' ) ) {
-	define( 'WP_CLI_ROOT', $wp_cli_phar_path );
+// Use the phar alias 'wp-cli.phar' which is set during phar creation and works
+// regardless of the actual filename. This ensures template paths resolve correctly.
+if ( file_exists( 'phar://wp-cli.phar/php/wp-cli.php' ) ) {
+	define( 'WP_CLI_ROOT', 'phar://wp-cli.phar' );
 	include WP_CLI_ROOT . '/php/wp-cli.php';
-} elseif ( file_exists( $wp_cli_phar_path . '/vendor/wp-cli/wp-cli/php/wp-cli.php' ) ) {
-	define( 'WP_CLI_ROOT', $wp_cli_phar_path . '/vendor/wp-cli/wp-cli' );
+} elseif ( file_exists( 'phar://wp-cli.phar/vendor/wp-cli/wp-cli/php/wp-cli.php' ) ) {
+	define( 'WP_CLI_ROOT', 'phar://wp-cli.phar/vendor/wp-cli/wp-cli' );
 	include WP_CLI_ROOT . '/php/wp-cli.php';
 } else {
 	echo "Couldn't find 'php/wp-cli.php'. Was this Phar built correctly?";