Skip to content

Pin some GitHub Actions #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Mar 26, 2026
Merged

Pin some GitHub Actions #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
if: ${{ github.repository_owner == 'wp-cli' }}
steps:
- name: Check out source code
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

- name: Set up PHP environment
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2
Comment on lines 18 to +22
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout and setup-php are pinned to SHAs now, but this workflow still uses other actions via mutable refs (notably ad-m/github-push-action@master, plus several @v* tags like ramsey/composer-install@v3 and actions/*-artifact@v7/v8). To reduce supply-chain risk and keep the workflow consistent with other pinned workflows in this repo, please pin these remaining actions to full commit SHAs (optionally keeping a # vX comment).

Copilot uses AI. Check for mistakes.
with:
php-version: 'latest'
extensions: mysql, zip, imagick
Expand Down Expand Up @@ -107,15 +107,15 @@ jobs:
if: ${{ github.repository_owner == 'wp-cli' }}
steps:
- name: Check out source code
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

- name: Install Ghostscript
run: |
sudo apt-get update
sudo apt-get install ghostscript -y

- name: Set up PHP environment
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2
with:
php-version: '${{ matrix.php }}'
extensions: imagick, mysql, zip
Expand Down Expand Up @@ -189,7 +189,7 @@ jobs:
if: ${{ github.repository_owner == 'wp-cli' && github.event_name != 'workflow_dispatch' }}
steps:
- name: Check out builds repository
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
repository: wp-cli/builds
token: ${{ secrets.ACTIONS_BOT }}
Expand Down Expand Up @@ -264,7 +264,7 @@ jobs:

steps:
- name: Check out builds repository
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
repository: wp-cli/builds
token: ${{ secrets.ACTIONS_BOT }}
Expand Down Expand Up @@ -318,7 +318,7 @@ jobs:

steps:
- name: Check out builds repository
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
repository: wp-cli/builds
token: ${{ secrets.ACTIONS_BOT }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-framework.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
if: ${{ github.repository_owner == 'wp-cli' }}
steps:
- name: Check out source code
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

- name: Set up PHP environment
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2
Comment on lines 26 to +30
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now pins actions/checkout and setup-php to SHAs, but other third-party actions in the same file are still referenced via mutable tags (e.g. ramsey/composer-install@v3 and repo-sync/pull-request@v2). Given the repo already pins actions to SHAs elsewhere (see .github/workflows/copilot-setup-steps.yml), consider pinning the remaining actions here as well to avoid supply-chain risk and keep the workflow consistent.

Copilot uses AI. Check for mistakes.
with:
php-version: 'latest'
env:
Expand Down
Loading