Add granular MCP tool annotations for destructive and idempotent hints#15
Merged
Conversation
Refactor Abilities to separate core annotations (readonly, destructive, idempotent) from MCP protocol hints (readOnlyHint, destructiveHint, idempotentHint), and expose both via a new meta_annotations field. Add an optional $annotations parameter to add_ability() so callers can override defaults per-tool. Apply destructive=true and idempotent=true to delete operations across all tool files, and idempotent=true to update/activate/save operations where appropriate. Extend tests/run.php to assert correct annotation values on both MCP tool hints and registered ability meta.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Abilities to separate core annotations (readonly, destructive, idempotent) from MCP protocol hints (readOnlyHint, destructiveHint, idempotentHint), and expose both via a new meta_annotations field.
Add an optional $annotations parameter to add_ability() so callers can override defaults per-tool. Apply destructive=true and idempotent=true to delete operations across all tool files, and idempotent=true to update/activate/save operations where appropriate.
Extend tests/run.php to assert correct annotation values on both MCP tool hints and registered ability meta.