fix: address WordPress.org plugin review (rename + prefixing + headers)#1019
Merged
kidunot89 merged 6 commits intoJun 30, 2026
Merged
Conversation
df76b47 to
46a421a
Compare
Coverage Report for CI Build 28450585642Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 91.801%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
- Prefix the session transaction queue transient with the plugin's graphql_woocommerce_ namespace instead of the generic "woo_" word, to avoid collisions (Plugin Directory: prefix data storage). - Declare the WooCommerce dependency via the "Requires Plugins: woocommerce" plugin header. - Bump README.txt "Tested up to" to 7.0. - Ship composer.json in the distributed plugin (drop it, and composer.lock, from composer archive excludes) so the build is reproducible/reviewable.
The WordPress.org plugin review flagged the display name/slug for beginning with the "WPGraphQL" trademark (and the "WooGraphQL" portmanteau of the WooCommerce mark), which can imply official affiliation. - Display name (plugin header + readme title) -> "GraphQL for eCommerce". - Slug/text domain -> "graphql-for-ecommerce" (header, all i18n string literals, and the PHPCS WordPress.WP.I18n text_domain config). - Update user-facing notices/errors that named the old plugin. "WooGraphQL" remains the project's informal nickname (repo, docs, community), just not in the WordPress.org directory's official name/slug. Internal file names and GitHub URLs are unchanged.
The committed manifest mirrors develop (lint/stan dev deps only); CI adds the test suite deps at runtime via `composer installTestEnv`. A previous commit captured the installTestEnv-modified composer.json, desyncing it from composer.lock and breaking `composer install` in CI.
Regenerate the lock from the manifest so it is in sync (fixes the CI `composer install` failure) and refresh dependencies in the process — firebase/php-jwt v7.0.4 -> v7.1.0 plus 11 others, with vendor-prefixed re-strauss'd to match. Full wpunit suite passes against the updated deps (305 tests, 835 assertions).
…raphql#1018 wp-graphql#1018 (createdVia + order attribution) merged into develop after the rename commit was authored, so its new i18n strings still used the old 'wp-graphql-woocommerce' text domain. Update them to 'graphql-for-ecommerce' to match the rename.
6a53d4c to
f03617c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What does this implement/fix? Explain your changes.
Addresses the issues raised in the WordPress.org Plugin Directory review.
Trademark / naming (the gating issue). The directory display name/slug began with the
WPGraphQLtrademark (andWooGraphQLis a portmanteau of the WooCommerce mark), which can imply official affiliation.README.txttitle) → GraphQL for eCommerce.WordPress.WP.I18ntext_domainconfig).WooGraphQLis kept only as the project's informal nickname (repo/docs/community), not in the directory's official name/slug. Internal file names and GitHub URLs are unchanged.Prefix data storage. The session transaction queue transient used the generic
woo_word; it now uses the plugin'sgraphql_woocommerce_namespace. (Audited the rest —define()s, options, and namespaced classes were already distinct.)Plugin headers / packaging.
Requires Plugins: woocommerce.README.txt"Tested up to" →7.0.composer.jsonin the distributed plugin (removed it, andcomposer.lock, from thecomposer archiveexcludes).Items reviewed and left as-is (compliant): the only
admin_noticesis acurrent_user_can-gated dependency-missing error (not an upgrade nag, Guideline 11), and there is no unprotected request handling — the one pre-auth$_GETdownload endpoint validates an HMAC token (a nonce doesn't apply to unauthenticated download links).Does this close any currently open issues?
…
Any relevant logs, error output, GraphiQL screenshots, etc?
composer lintandcomposer stanare clean. Full wpunit suite green after the rename:Any other comments?
The WordPress.org slug reservation (
graphql-for-ecommerce) still needs to be requested by replying to the review email — that part is on the WordPress.org side and is not a code change.