Skip to content

fix: address WordPress.org plugin review (rename + prefixing + headers)#1019

Merged
kidunot89 merged 6 commits into
wp-graphql:developfrom
kidunot89:fix/plugin-review-issues
Jun 30, 2026
Merged

fix: address WordPress.org plugin review (rename + prefixing + headers)#1019
kidunot89 merged 6 commits into
wp-graphql:developfrom
kidunot89:fix/plugin-review-issues

Conversation

@kidunot89

Copy link
Copy Markdown
Collaborator

Your checklist for this pull request

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic.

What does this implement/fix? Explain your changes.

Addresses the issues raised in the WordPress.org Plugin Directory review.

Trademark / naming (the gating issue). The directory display name/slug began with the WPGraphQL trademark (and WooGraphQL is a portmanteau of the WooCommerce mark), which can imply official affiliation.

  • Display name (plugin header + README.txt title) → GraphQL for eCommerce.
  • Slug / text domain → graphql-for-ecommerce (header, all i18n string literals across the plugin, and the PHPCS WordPress.WP.I18n text_domain config).
  • User-facing notices/errors that named the old plugin were updated.
  • WooGraphQL is kept only as the project's informal nickname (repo/docs/community), not in the directory's official name/slug. Internal file names and GitHub URLs are unchanged.

Prefix data storage. The session transaction queue transient used the generic woo_ word; it now uses the plugin's graphql_woocommerce_ namespace. (Audited the rest — define()s, options, and namespaced classes were already distinct.)

Plugin headers / packaging.

  • Added Requires Plugins: woocommerce.
  • README.txt "Tested up to" → 7.0.
  • Ship composer.json in the distributed plugin (removed it, and composer.lock, from the composer archive excludes).

Items reviewed and left as-is (compliant): the only admin_notices is a current_user_can-gated dependency-missing error (not an upgrade nag, Guideline 11), and there is no unprotected request handling — the one pre-auth $_GET download endpoint validates an HMAC token (a nonce doesn't apply to unauthenticated download links).

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

composer lint and composer stan are clean. Full wpunit suite green after the rename:

vendor/bin/codecept run wpunit
Tests: 304, Assertions: 833, Skipped: 2

Any other comments?

The WordPress.org slug reservation (graphql-for-ecommerce) still needs to be requested by replying to the review email — that part is on the WordPress.org side and is not a code change.

@kidunot89 kidunot89 force-pushed the fix/plugin-review-issues branch from df76b47 to 46a421a Compare June 12, 2026 00:25
@coveralls

coveralls commented Jun 12, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28450585642

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 91.801%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 257 uncovered changes across 83 files (1330 of 1587 lines covered, 83.81%).
  • 1 coverage regression across 1 file.

Uncovered Changes

Top 10 Files by Coverage Impact Changed Covered %
includes/type/object/class-root-query.php 74 49 66.22%
includes/data/mutation/class-checkout-mutation.php 17 1 5.88%
includes/type/interface/class-product-union.php 14 4 28.57%
includes/data/mutation/class-cart-mutation.php 9 3 33.33%
includes/mutation/class-order-note-delete.php 10 4 40.0%
includes/mutation/class-product-attribute-term-create.php 12 6 50.0%
includes/type/object/class-cart-error-types.php 12 6 50.0%
includes/connection/class-orders.php 13 8 61.54%
includes/mutation/class-product-attribute-term-delete.php 8 3 37.5%
includes/mutation/class-product-delete.php 8 3 37.5%
Total (201 files) 1587 1330 83.81%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
includes/mutation/class-product-attribute-term-create.php 1 86.41%

Coverage Stats

Coverage Status
Relevant Lines: 20186
Covered Lines: 18531
Line Coverage: 91.8%
Coverage Strength: 153.15 hits per line

💛 - Coveralls

- Prefix the session transaction queue transient with the plugin's
  graphql_woocommerce_ namespace instead of the generic "woo_" word, to
  avoid collisions (Plugin Directory: prefix data storage).
- Declare the WooCommerce dependency via the "Requires Plugins: woocommerce"
  plugin header.
- Bump README.txt "Tested up to" to 7.0.
- Ship composer.json in the distributed plugin (drop it, and composer.lock,
  from composer archive excludes) so the build is reproducible/reviewable.
The WordPress.org plugin review flagged the display name/slug for beginning
with the "WPGraphQL" trademark (and the "WooGraphQL" portmanteau of the
WooCommerce mark), which can imply official affiliation.

- Display name (plugin header + readme title) -> "GraphQL for eCommerce".
- Slug/text domain -> "graphql-for-ecommerce" (header, all i18n string
  literals, and the PHPCS WordPress.WP.I18n text_domain config).
- Update user-facing notices/errors that named the old plugin.

"WooGraphQL" remains the project's informal nickname (repo, docs, community),
just not in the WordPress.org directory's official name/slug. Internal file
names and GitHub URLs are unchanged.
The committed manifest mirrors develop (lint/stan dev deps only); CI adds the
test suite deps at runtime via `composer installTestEnv`. A previous commit
captured the installTestEnv-modified composer.json, desyncing it from
composer.lock and breaking `composer install` in CI.
Regenerate the lock from the manifest so it is in sync (fixes the CI
`composer install` failure) and refresh dependencies in the process —
firebase/php-jwt v7.0.4 -> v7.1.0 plus 11 others, with vendor-prefixed
re-strauss'd to match. Full wpunit suite passes against the updated deps
(305 tests, 835 assertions).
…raphql#1018

wp-graphql#1018 (createdVia + order attribution) merged into develop after the rename
commit was authored, so its new i18n strings still used the old
'wp-graphql-woocommerce' text domain. Update them to 'graphql-for-ecommerce'
to match the rename.
@kidunot89 kidunot89 force-pushed the fix/plugin-review-issues branch from 6a53d4c to f03617c Compare June 13, 2026 01:26
@kidunot89 kidunot89 added the dev-ops PR resolves an issue or implements a feature related to the development process label Jun 17, 2026
@kidunot89 kidunot89 merged commit 088d337 into wp-graphql:develop Jun 30, 2026
21 checks passed
@kidunot89 kidunot89 deleted the fix/plugin-review-issues branch June 30, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-ops PR resolves an issue or implements a feature related to the development process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants