Skip to content

Closes #8294 RocketCDN Free Tier: Handle driver tab switch data#8295

Merged
jeawhanlee merged 5 commits into
feature/8262-rocketcdn-backend-logic-2from
feature/8294-handle-driver-tab
May 11, 2026
Merged

Closes #8294 RocketCDN Free Tier: Handle driver tab switch data#8295
jeawhanlee merged 5 commits into
feature/8262-rocketcdn-backend-logic-2from
feature/8294-handle-driver-tab

Conversation

@Khadreal
Copy link
Copy Markdown
Contributor

@Khadreal Khadreal commented May 7, 2026

Description

Fixes #8294

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Chore
  • Release

Detailed scenario

What was tested

Created an auto test for the endpoint.

How to test

can't be test in isolation for now until merge with other pr

Affected Features & Quality Assurance Scope

n/a

Technical description

Documentation

Created an endpoint for saving cdn active driver.

New dependencies

n/a

Risks

n/a

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

nil

@Khadreal Khadreal changed the title Feature/8294 handle driver tab Closes #8294 RocketCDN Free Tier: Handle driver tab switch data May 7, 2026
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 7, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.03% coverage variation

Metric Results
Coverage variation +0.03% coverage variation (-0.10%)
Diff coverage 100.00% diff coverage (50.00%)

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (362f220) 43336 20034 46.23%
Head commit (d2fe5ce) 43363 (+27) 20061 (+27) 46.26% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#8295) 27 27 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Khadreal Khadreal linked an issue May 7, 2026 that may be closed by this pull request
@Khadreal Khadreal requested a review from a team May 7, 2026 15:22
Comment thread inc/Engine/CDN/RocketCDN/Rest.php Outdated
@Khadreal Khadreal self-assigned this May 8, 2026
@Khadreal Khadreal requested a review from jeawhanlee May 8, 2026 08:49
@jeawhanlee jeawhanlee merged commit fbfbc40 into feature/8262-rocketcdn-backend-logic-2 May 11, 2026
15 checks passed
@jeawhanlee jeawhanlee deleted the feature/8294-handle-driver-tab branch May 11, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RocketCDN Free Tier: Handle driver tab switch data

2 participants