Skip to content

Simple Travis secret #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szepeviktor wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −6
Open

Simple Travis secret #3

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aae0dc
Simple Travis secret
szepeviktor Sep 24, 2020
b668368
Do not write private key to disk
szepeviktor Sep 29, 2020
5c8b1a3
Decode private key
szepeviktor Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ cache:
- $HOME/.composer/cache
- repos/wordpress

before_install:
Copy link
Copy Markdown
Member

@aaemnnosttv aaemnnosttv Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this to before_install? The install step only runs Composer, which does not require SSH (only the script does). The key is actually really only needed for the deploy step but I seem to recall the git clone would fail without it using ssh for the remote.

Copy link
Copy Markdown
Author

@szepeviktor szepeviktor Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install does the installation of Composer packages which are actually part of this software.
before_install does the prerequisites for running CI.
I hope that is clear :)

- eval "$(ssh-agent -s)"
- echo -n "${base64_4950820e8b20_key}" | base64 --decode >.travis/key
- chmod 600 .travis/key
- ssh-add .travis/key
Copy link
Copy Markdown
Member

@aaemnnosttv aaemnnosttv Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If extracting the key to a secret (which seems to be what you're suggesting here), then the encrypted key in the repo is no longer needed either since ssh-add can read from STDIN (see this answer).

Copy link
Copy Markdown
Author

@szepeviktor szepeviktor Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


install: travis_retry composer install --no-dev --prefer-dist

script: bin/build
Expand All @@ -22,9 +28,3 @@ deploy:
script: bin/deploy
on:
branch: master

before_script:
- openssl aes-256-cbc -K $encrypted_4950820e8b20_key -iv $encrypted_4950820e8b20_iv -in .travis/key.enc -out .travis/key -d
- eval "$(ssh-agent -s)"
- chmod 600 .travis/key
- ssh-add .travis/key