Skip to content

fix: #2085 update Apollo Client devtools option#2086

Merged
colinmurphy merged 3 commits intowpengine:canaryfrom
cedricrabarijohn:fix/apollo-client-devtools-option
Apr 7, 2025
Merged

fix: #2085 update Apollo Client devtools option#2086
colinmurphy merged 3 commits intowpengine:canaryfrom
cedricrabarijohn:fix/apollo-client-devtools-option

Conversation

@cedricrabarijohn
Copy link
Copy Markdown
Contributor

@cedricrabarijohn cedricrabarijohn commented Mar 24, 2025

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Updated devtools option of the apollo client, related to #2085

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@cedricrabarijohn cedricrabarijohn requested a review from a team as a code owner March 24, 2025 23:02
@headless-platform-by-wp-engine
Copy link
Copy Markdown

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: c7da0c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colinmurphy
Copy link
Copy Markdown
Member

@cedricrabarijohn

Thank you for contributing to Faust 🚀

We will review this PR today.

Can you add a changeset to PR and also fix conflicts for packages/faustwp-core/src/client.ts . We recently merged in changes for a Next vulnerability so you might need to update your branch.

Finally can you also sign the CLA too please and confirm in the task description - https://github.com/wpengine/faustjs#contributor-license-agreement

@colinmurphy
Copy link
Copy Markdown
Member

@cedricrabarijohn

Can you rebase your branch to the latest version of Faust please. I tested this locally but your version of @faustwp/core is 3.1.0 and currently @faustwp/core is 3.2.1.

I was able to get this to work locally and thanks again for your contribution to Faust.

@cedricrabarijohn cedricrabarijohn force-pushed the fix/apollo-client-devtools-option branch from db5401b to 3e6c7bc Compare March 26, 2025 11:17
@cedricrabarijohn
Copy link
Copy Markdown
Contributor Author

Hey @colinmurphy thanks for your answer.
About the CLA, I've already submitted the form but for some reasons I didn't get any mails from it, maybe could you take a look ?

@colinmurphy
Copy link
Copy Markdown
Member

Thanks @cedricrabarijohn

Sorry about not getting the email. I am actively looking into this and we will get back either today or tomorrow once we have this sorted.

Thanks for updating the branch aswell

@colinmurphy
Copy link
Copy Markdown
Member

@cedricrabarijohn

Apologies but our CLA form process was broken so we had to create a new form.

Would you mind re-filling in your information into the new CLA form here please - https://docs.google.com/forms/d/e/1FAIpQLSei-8D4iWmUKWbJI9Ck-81X8ZquXRhMH3D98RogAgbqqh5CkA/viewform

@cedricrabarijohn
Copy link
Copy Markdown
Contributor Author

cedricrabarijohn commented Apr 1, 2025

Re @colinmurphy

Thank you for the feedback ! I successfully filled the form with my email address and my name, but it seems that I didn't receive any mail back. And sorry I think I filled the form 3 times thinking I was doing something wrong

I also checked in my spam box but still nothing

@colinmurphy
Copy link
Copy Markdown
Member

Thanks @cedricrabarijohn

Apologies we have a manual step on our end. Can you confirm if you got the CLA form now to sign?

Thanks again for your patience.

@cedricrabarijohn
Copy link
Copy Markdown
Contributor Author

Thank you @colinmurphy I received it !

@colinmurphy
Copy link
Copy Markdown
Member

Thanks @cedricrabarijohn 😄

Sorry I will test this and the other PR today and if not latest Monday and we will get these merged once too.

Thanks again for your patience. We are also looking at improving the current CLA process too.

Copy link
Copy Markdown
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedricrabarijohn

LGTM 🚀

Thank you for your contribution to Faust. I will merge this now and we will do a release on Monday 🚀

@colinmurphy
Copy link
Copy Markdown
Member

@cedricrabarijohn

There is a small formatting issue and we cannot merge as the Github action for checking formatting is failing.

Can you do the following

cd cd packages/faustwp-core && nvm use && npm run format.

That will fix any formatting issues with prettier.

Once fixed I can merge and do a release early next week.

@cedricrabarijohn
Copy link
Copy Markdown
Contributor Author

@colinmurphy done 🚀🚀

@colinmurphy colinmurphy merged commit 1ea9dc3 into wpengine:canary Apr 7, 2025
18 checks passed
@headless-platform-by-wp-engine
Copy link
Copy Markdown

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

@colinmurphy
Copy link
Copy Markdown
Member

Thanks @cedricrabarijohn 🚀

Both your PR's have now been released as part of the latest Faust release. Let us know if you have any further issues.

Thanks again for your contribution 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants