fix: #2085 update Apollo Client devtools option#2086
fix: #2085 update Apollo Client devtools option#2086colinmurphy merged 3 commits intowpengine:canaryfrom
Conversation
|
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. |
🦋 Changeset detectedLatest commit: c7da0c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you for contributing to Faust 🚀 We will review this PR today. Can you add a changeset to PR and also fix conflicts for Finally can you also sign the CLA too please and confirm in the task description - https://github.com/wpengine/faustjs#contributor-license-agreement |
|
Can you rebase your branch to the latest version of Faust please. I tested this locally but your version of @faustwp/core is 3.1.0 and currently @faustwp/core is 3.2.1. I was able to get this to work locally and thanks again for your contribution to Faust. |
db5401b to
3e6c7bc
Compare
|
Hey @colinmurphy thanks for your answer. |
|
Thanks @cedricrabarijohn Sorry about not getting the email. I am actively looking into this and we will get back either today or tomorrow once we have this sorted. Thanks for updating the branch aswell |
|
Apologies but our CLA form process was broken so we had to create a new form. Would you mind re-filling in your information into the new CLA form here please - https://docs.google.com/forms/d/e/1FAIpQLSei-8D4iWmUKWbJI9Ck-81X8ZquXRhMH3D98RogAgbqqh5CkA/viewform |
|
Re @colinmurphy Thank you for the feedback ! I successfully filled the form with my email address and my name, but it seems that I didn't receive any mail back. And sorry I think I filled the form 3 times thinking I was doing something wrong I also checked in my spam box but still nothing |
|
Thanks @cedricrabarijohn Apologies we have a manual step on our end. Can you confirm if you got the CLA form now to sign? Thanks again for your patience. |
|
Thank you @colinmurphy I received it ! |
|
Thanks @cedricrabarijohn 😄 Sorry I will test this and the other PR today and if not latest Monday and we will get these merged once too. Thanks again for your patience. We are also looking at improving the current CLA process too. |
colinmurphy
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thank you for your contribution to Faust. I will merge this now and we will do a release on Monday 🚀
|
There is a small formatting issue and we cannot merge as the Github action for checking formatting is failing. Can you do the following
That will fix any formatting issues with prettier. Once fixed I can merge and do a release early next week. |
|
@colinmurphy done 🚀🚀 |
|
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. |
|
Thanks @cedricrabarijohn 🚀 Both your PR's have now been released as part of the latest Faust release. Let us know if you have any further issues. Thanks again for your contribution 🚀 |
Tasks
Description
Updated devtools option of the apollo client, related to #2085
Related Issue(s):
Testing
Screenshots
Documentation Changes
Dependant PRs