Skip to content

Fixing Github action for canary branch#2094

Merged
theodesp merged 2 commits intocanaryfrom
chore-fix-gh-actions-release-canary
Apr 3, 2025
Merged

Fixing Github action for canary branch#2094
theodesp merged 2 commits intocanaryfrom
chore-fix-gh-actions-release-canary

Conversation

@colinmurphy
Copy link
Copy Markdown
Member

@colinmurphy colinmurphy commented Apr 3, 2025

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Currently we cannot merge the canary branch - #2092

This should fix those issues.

Attaching screenshot from the first commit which also ran those actions for this branch

Screenshot 2025-04-03 at 15 51 40

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: ebb6a3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@colinmurphy colinmurphy requested a review from theodesp April 3, 2025 14:57
@colinmurphy colinmurphy marked this pull request as ready for review April 3, 2025 14:57
@colinmurphy colinmurphy requested a review from a team as a code owner April 3, 2025 14:57
@theodesp theodesp merged commit 0f30080 into canary Apr 3, 2025
18 checks passed
@theodesp theodesp deleted the chore-fix-gh-actions-release-canary branch April 3, 2025 15:54
@moonmeister
Copy link
Copy Markdown
Member

This is not how you fix this

@moonmeister
Copy link
Copy Markdown
Member

What was the actual issue? The problem I saw last week was that I set this to ignore certain files.

    paths-ignore:
      - '**/*.md'
      - '**/*.php'

So making documentation and non-code changes meant these required checks never ran. Was there a different issue?

moonmeister added a commit that referenced this pull request Apr 3, 2025
moonmeister added a commit that referenced this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants