Fix the_content link replacements#2104
Conversation
🦋 Changeset detectedLatest commit: 2e29c46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
I will try and have a look tomorrow at why those tests are failing. |
|
I believe the e2e issue is related to - #2089 |
As per issue #2089 there is a cache issue with using npx create app for the example tutorial on Github's side. Not sure why it is only failing for this branch though.
…e example directory
colinmurphy
left a comment
There was a problem hiding this comment.
I fixed the e2e bug.
Can we also add tests for what this fixes too please. Thank you for fixing this but I think it would be useful to have new tests too which act as documentation too.
colinmurphy
left a comment
There was a problem hiding this comment.
This PR looks great 🚀 🚀 🚀
Thanks for adding in the tests and also for fixing the issues with ports ❤️
|
Can you also add a changeset for this too please. You should be able to add one clicking on the link above but let me know if you need any help. |
Tasks
Description
Fix duplicate links and port not taken into account.
1.1 If NOT enabled - use the WordPress URL
2.1 If NOT enabled - use front-end url
Related Issue(s):
Provide the GitHub issue(s) number for issue tracking purposes, use the following syntax:
Bug: Fixes issues for content replacement for the site and media URLs #2014
Testing
Sample post with images, csv/pdf, an internal link.
The expected result must be:
1.1 If NOT enabled - use the WordPress URL
2.1 If NOT enabled - use front-end url
Screenshots
Documentation Changes
Dependant PRs