Skip to content

chore: Testing with WordPress 6.8#2107

Merged
colinmurphy merged 2 commits intocanaryfrom
chore-update-faust-wordpress-6.8
Apr 16, 2025
Merged

chore: Testing with WordPress 6.8#2107
colinmurphy merged 2 commits intocanaryfrom
chore-update-faust-wordpress-6.8

Conversation

@colinmurphy
Copy link
Copy Markdown
Member

@colinmurphy colinmurphy commented Apr 16, 2025 •
edited
Loading

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

PR for testing Faust with WordPress 6.8
Also add minor change as per team agreement that we shouldn't be checking CHANGELOG files for linting rules and preventing PR merges.

Related Issue(s):

Fixes #2106

Testing

  1. Tested with a single and multisite
  2. Updated test suite to test against 6.8

Screenshots

Documentation Changes

N/A

Dependant PRs

N/A

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2025 •
edited
Loading

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@colinmurphy
Added pattern to ignore CHANGELOG.md
02c4c91 
Due to recent issues with PRs and needing to reformat the CHANGELOG.md files
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 02c4c91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI reviewed Apr 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Faust plugin to ensure compatibility and testing support for WordPress 6.8.

  • Updated the "Tested up to" version in the readme file.
  • Modified the docker-compose configuration to default to WordPress 6.8.
  • Expanded the unit test matrix to include WordPress 6.8.

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
plugins/faustwp/readme.txt Updated tested version from 6.7.2 to 6.8.0
plugins/faustwp/docker-compose.yml Changed default WP_VERSION from 6.7 to 6.8
.github/workflows/unit-test-plugin.yml Added WordPress 6.8 to the unit test matrix
Files not reviewed (2)
  • package.json: Language not supported
  • plugins/faustwp/faustwp.php: Language not supported

@colinmurphy colinmurphy mentioned this pull request Apr 16, 2025
Closed
1 task
@colinmurphy colinmurphy changed the title Tested Faust with 6.8 and updated test suite and "Tested to" for 6.8. chore: Testing with WordPress 6.8 Apr 16, 2025
@colinmurphy colinmurphy marked this pull request as ready for review April 16, 2025 17:30
@colinmurphy colinmurphy requested a review from a team as a code owner April 16, 2025 17:30
@colinmurphy colinmurphy merged commit 9ad752d into canary Apr 16, 2025
19 checks passed
@colinmurphy colinmurphy deleted the chore-update-faust-wordpress-6.8 branch April 16, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@theodesp theodesp theodesp approved these changes

@josephfusco josephfusco Awaiting requested review from josephfusco

@ahuseyn ahuseyn Awaiting requested review from ahuseyn

@whoami-pwd whoami-pwd Awaiting requested review from whoami-pwd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: Testing with WordPress 6.8

3 participants

@colinmurphy @theodesp