Skip to content

[next]: Add data fetching and preview#2154

Merged
ahuseyn merged 10 commits into
nextfrom
next-add-data-fetching
Aug 28, 2025
Merged

[next]: Add data fetching and preview#2154
ahuseyn merged 10 commits into
nextfrom
next-add-data-fetching

Conversation

@ahuseyn
Copy link
Copy Markdown
Member

@ahuseyn ahuseyn commented Aug 20, 2025

Description

This PR adds following:

  • data-fetching package. This is an initial phase of the package. Could be merged with template-hierarchy or graphql in the future or stand as is.
  • enablePreview utility for the nextjs adapter. It gives a customizable API handler to enable the Draft Mode.
  • kitchen-sink example for Nextjs to include all the available features (template-hierarchy, previews, data-fetching). It'll be the working ground for future development.

and updates following:

  • graphql client package to fix some errors and allow custom headers for auth
  • templateHierarchy.js to add seedNode property to templateData. We should remove seedQuery in favor of seedNode, as it better represents the value assigned to it.
  • seedQueryExecutor.js to add databaseId and asPreview parameters

Related Issue(s):

@ahuseyn ahuseyn requested a review from a team as a code owner August 20, 2025 11:58
This was linked to issues Aug 20, 2025
[experimental]: PoC Previews + Nextjs Implementation #2151
Open
[experimental]: GraphQL Data Fetching Support #2150
Open
@ahuseyn ahuseyn changed the title Next add data fetching [next]: Add data fetching and preview Aug 20, 2025
This was referenced Aug 22, 2025
Merged
Closed
josephfusco
josephfusco approved these changes Aug 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@josephfusco josephfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ahuseyn!

I left some non-blocking feedback to consider.

Comment thread packages/data-fetching/fetchTemplateQueries.js
return client.request(print(query), queryVariables);
});

const results = await Promise.all(queryCalls);
Copy link
Copy Markdown
Member

@josephfusco josephfusco Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using Promise.allSettled instead of Promise.all

This would allow successful queries to return even if one fails.

Copy link
Copy Markdown
Member Author

@ahuseyn ahuseyn Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe, my initial motivation to use Promise.all was this comment, but we should definitely reevaluate that approach in new Faust.

@ahuseyn ahuseyn merged commit c39b4ac into next Aug 28, 2025
0 of 13 checks passed
@ahuseyn ahuseyn deleted the next-add-data-fetching branch August 28, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephfusco josephfusco josephfusco approved these changes

@moonmeister moonmeister Awaiting requested review from moonmeister

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[experimental]: PoC Previews + Nextjs Implementation [experimental]: GraphQL Data Fetching Support

2 participants

@ahuseyn @josephfusco