fix[auth]: Sanitize URL in cookie key to make it RFC 6265 compliant#2183
Merged
fix[auth]: Sanitize URL in cookie key to make it RFC 6265 compliant#2183
Conversation
….1.1 compliant
🦋 Changeset detectedLatest commit: 7026f8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 task
1 task
colinmurphy
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
Description
This pull request focuses on improving RFC 6265 compliance for cookie keys in the
@faustwp/corepackage by sanitizing the URL used in the cookie key. This ensures that the cookie key only contains valid characters, preventing potential issues with cookie handling in browsers.Cookie key compliance improvements:
tokenKeyin theOAuthclass (token.ts) to sanitize the URL, removing any characters not allowed by RFC 6265 section 4.1.1. This change helps prevent invalid cookie keys and improves compatibility across browsers.Related Issue(s):
Testing
Tested manually with faustwp-getting-started example
Screenshots
Documentation Changes
Dependant PRs