fix(faustwp): clarify wp.org updater-exclusion intent in code and verifier#2424
Conversation
…ifier Reword the file_exists comment in faustwp.php so the wp.org-only execution rule is explicit, qualify the 1.5.0 self-update changelog entry so historical mentions rotated into readme.txt carry the right scope, and add an explicit verifier assertion that the wp.org artifact contains no self-update files.
|
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Pull request overview
This PR clarifies the intended “no self-updater on WordPress.org” behavior for the FaustWP plugin by tightening in-code explanations, scoping a changelog note so it remains accurate if surfaced in readme.txt, and adding an extra verification guard to ensure the published wp.org artifact does not include external updater infrastructure.
Changes:
- Adds a defense-in-depth check in
verify-published-plugin.shto assert wp.org-installed artifacts do not contain the embedded self-updater files. - Rewords the updater
requirecomment infaustwp.phpto explain when those files should be present. - Qualifies the 1.5.0 changelog entry to explicitly apply only to non-wp.org distributions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/verify-published-plugin.sh | Adds an additional assertion to fail verification if self-updater files are present in the installed (wp.org) artifact. |
| plugins/faustwp/faustwp.php | Updates comments around optional updater file loading to clarify distribution expectations. |
| plugins/faustwp/CHANGELOG.md | Adjusts the 1.5.0 entry to scope self-updater functionality to non-wp.org distributions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Rewords the conditional require comment in
faustwp.phpto state the wp.org-only execution rule explicitly, qualifies the 1.5.0 self-update CHANGELOG entry as non-wordpress.org-only so it stays correctly scoped if it rotates intoreadme.txt, and adds a defense-in-depth assertion inverify-published-plugin.shthat the wp.org-published artifact contains no self-update files.