ci(faustwp): wrap release zips in a faustwp/ top-level directory#2438
Merged
Conversation
Both zip steps in the release-plugin composite action ran `cd dist/faustwp && zip -r ../../foo.zip .`, which zipped the contents of the slug directory instead of the directory itself. Manual installs and downloads from GitHub Releases extracted as loose files in the current directory instead of into faustwp/. Zip from the parent dist/ instead, passing the slug as the directory to recurse into, so faustwp/ becomes the archive's top-level entry. SVN deploys via 10up's action are unaffected because they consume the dist/faustwp directory directly.
|
Contributor
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the wrapping
faustwp/directory at the top of bothfaustwp.X.Y.Z.zipandfaustwp.X.Y.Z.org.zipso manual installs and debugging downloads from GitHub Releases extract correctly; should be merged before #2437 so the 1.8.11 tag picks up the fix.