Refactoring @josephfusco work for plugin slug into a re-usable bash script to help reduce duplicate code for the various workflows.

Author: colinmurphy

.github/scripts/get-plugin-slug.sh

@@ -0,0 +1,43 @@
+#!/usr/bin/env bash
+
+set -e
+
+BASE_SHA="$1"
+HEAD_SHA="$2"
+
+git fetch --prune --unshallow
+
+# Get changed files in plugins subdirectories
+CHANGED_FILES=$(git diff --name-only "$BASE_SHA" "$HEAD_SHA" | grep '^plugins/[^/]\+/' || true)
+
+if [ -z "$CHANGED_FILES" ]; then
+  echo "No plugin files changed"
+  exit 1
+fi
+
+# Extract plugin names from both old and new paths
+PLUGINS=()
+for file in $CHANGED_FILES; do
+  plugin=$(echo $file | cut -d/ -f2)
+  PLUGINS+=("$plugin")
+done
+
+# Get unique plugin names
+UNIQUE_PLUGINS=($(printf '%s\n' "${PLUGINS[@]}" | sort -u))
+
+# Find the first plugin that actually exists
+PLUGIN_SLUG=""
+for plugin in "${UNIQUE_PLUGINS[@]}"; do
+  if [ -d "plugins/$plugin" ]; then
+    PLUGIN_SLUG="$plugin"
+    echo "Found existing plugin directory: $PLUGIN_SLUG"
+    break
+  fi
+done
+
+if [ -z "$PLUGIN_SLUG" ]; then
+  echo "No valid plugin directory found"
+  exit 1
+fi
+
+echo "slug=$PLUGIN_SLUG" >> "$GITHUB_OUTPUT"

.github/workflows/plugin-artifact-for-pr.yml

@@ -20,9 +20,7 @@ jobs:
       - name: Get changed plugin directory
         id: plugin
         run: |
-          git fetch --prune --unshallow
-          plugin=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | grep '^plugins/' | head -1 | cut -d/ -f2)
-          echo "slug=$plugin" >> $GITHUB_OUTPUT
+          bash .github/scripts/get-plugin-slug.sh ${{ github.event.pull_request.base.sha }} ${{ github.sha }}
 
       - name: Create plugin artifact
         uses: ./.github/actions/create-plugin-artifact
@@ -44,20 +42,20 @@ jobs:
             const artifactUrl = `https://github.com/${context.repo.owner}/${context.repo.repo}/actions/runs/${runId}`;
             const slug = process.env.PLUGIN_SLUG;
             const body = `ℹ️ [Download the latest ${slug} plugin zip from this PR](${artifactUrl})\n<em>(See the 'Artifacts' section at the bottom)</em>`;
-            
+
             // Find existing comment from this bot
             const comments = await github.rest.issues.listComments({
               issue_number: pr.number,
               owner: context.repo.owner,
               repo: context.repo.repo
             });
-            
-            const botComment = comments.data.find(comment => 
-              comment.user.type === 'Bot' && 
+
+            const botComment = comments.data.find(comment =>
+              comment.user.type === 'Bot' &&
               comment.user.login === 'github-actions[bot]' &&
               comment.body.includes(`ℹ️ [Download the latest ${slug} plugin zip from this PR]`)
             );
-            
+
             if (botComment) {
               // Update existing comment
               core.info(`Updating existing comment with ID: ${botComment.id}`);