Skip to content

fix: add unsaved changes warning#264

Merged
ahuseyn merged 1 commit into
mainfrom
previews-unsaved-changes-warning
Jun 18, 2025
Merged

fix: add unsaved changes warning#264
ahuseyn merged 1 commit into
mainfrom
previews-unsaved-changes-warning

Conversation

@ahuseyn
Copy link
Copy Markdown
Member

@ahuseyn ahuseyn commented Jun 18, 2025

Description

This PR adds a beforeUnload event handler to warn users about unsaved changes.

Related Issue

Dependant PRs

N/A

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Manual, e2e

Screenshots

Screenshot 2025-06-18 at 17 31 59

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@ahuseyn ahuseyn requested a review from colinmurphy June 18, 2025 15:33
@ahuseyn ahuseyn requested a review from a team as a code owner June 18, 2025 15:33
@ahuseyn ahuseyn linked an issue Jun 18, 2025 that may be closed by this pull request
1 task
@github-actions
Copy link
Copy Markdown

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

Copy link
Copy Markdown
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuseyn Nice :) 🚀

@ahuseyn ahuseyn added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 760a87c Jun 18, 2025
3 checks passed
@ahuseyn ahuseyn deleted the previews-unsaved-changes-warning branch June 18, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug](previews): Loosing config changes

2 participants