Skip to content

Avoid redefining variables on each iteration #112

@IanDelMar

Description

@IanDelMar

foreach( $transports as $key => $transport ) {
$urls = array(
'default' => POST_SMTP_URL . '/Postman/Wizard/assets/images/smtp.png',
'smtp' => POST_SMTP_URL . '/Postman/Wizard/assets/images/smtp.png',
'gmail_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/gmail.png',
'mandrill_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/mandrill.png',
'sendgrid_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/sendgrid.png',
'mailgun_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/mailgun.png',
'sendinblue_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/brevo.png',
'postmark_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/postmark.png',
'sparkpost_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/sparkpost.png',
'mailjet_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/mailjet.png',
'sendpulse_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/sendpulse.png',
'smtp2go_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/smtp2go.png',
'office365_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/ms365.png',
'elasticemail_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/elasticemail.png',
'aws_ses_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/amazon.png',
'zohomail_api' => POST_SMTP_URL . '/Postman/Wizard/assets/images/zoho.png'
);

$urls is redefined on each iteration. However, the content of $urls does not change during the loop. Hence, $urls should be defined outside the loop.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions