Fix iterator failures with h5py 3.16 #1231
Merged
Merged
Conversation
ddkohler
changed the title
ddkohler
changed the title
ddkohler
requested review from
darienmorrow,
kameyer226,
ksunden,
rpm4 and
untzag
as code owners
rpm4
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to work with h5py 3.16.
In this fix, we point iterators that yield WrightTools class instances (Collection, Data, Channel, etc.) to run through
wt.Group.__getitem__, which wraps the h5py objects into our objects.Changes
Checklist
updated documentation, if applicable