fix(platform-api): align upstreamDefinition timeout and weight validation with the gateway

Restrict an upstreamDefinition connect timeout to ms, s, m, or h units. time.ParseDuration alone also accepts ns/us units and compound values like 1h30m that the gateway rejects at deploy, so without this an API saves at the control plane and then fails to deploy. This matches the connect pattern already published in the OpenAPI spec.

Set the upstream weight schema minimum to 0 to match the validator and the gateway, which both accept a 0..100 range.

Author: mehara-rothila

platform-api/src/internal/service/api.go

@@ -673,6 +673,12 @@ func (s *APIService) validateSubscriptionPlans(planNames *[]string, orgUUID stri
 // referenceable and deployable at the gateway.
 var upstreamRefNameRe = regexp.MustCompile(`^[a-zA-Z0-9\-_]+$`)
 
+// connectTimeoutRe is the contract an upstreamDefinition connect timeout must match: a whole or
+// decimal value in ms, s, m, or h. It mirrors the connect pattern published in the OpenAPI spec
+// and the gateway validator, since time.ParseDuration alone also accepts ns/us units and compound
+// values like "1h30m" that the gateway rejects at deploy.
+var connectTimeoutRe = regexp.MustCompile(`^\d+(\.\d+)?(ms|s|m|h)$`)
+
 // validHTTPMethods is the set of operation methods the gateway accepts.
 var validHTTPMethods = map[string]bool{
 	"GET": true, "POST": true, "PUT": true, "DELETE": true, "PATCH": true, "HEAD": true, "OPTIONS": true,
@@ -745,6 +751,9 @@ func (s *APIService) validateUpstreamRefs(upstreamDefs *[]api.ReusableUpstream,
 				if dur <= 0 {
 					return fmt.Errorf("upstreamDefinitions %q timeout.connect %q must be positive", d.Name, *d.Timeout.Connect)
 				}
+				if !connectTimeoutRe.MatchString(*d.Timeout.Connect) {
+					return fmt.Errorf("upstreamDefinitions %q timeout.connect %q must use unit ms, s, m, or h (e.g. 5s, 500ms)", d.Name, *d.Timeout.Connect)
+				}
 			}
 			defined[d.Name] = true
 		}

platform-api/src/internal/service/api_test.go

@@ -676,6 +676,17 @@ func TestValidateUpstreamRefs(t *testing.T) {
 			t.Errorf("expected nil for valid timeout.connect, got %v", err)
 		}
 	})
+	t.Run("non-canonical timeout.connect unit rejected", func(t *testing.T) {
+		// time.ParseDuration accepts these, but the gateway only allows ms, s, m, h, so the
+		// control plane must reject them too or the API saves and then fails to deploy.
+		for _, v := range []string{"1h30m", "500ns", "500us"} {
+			d := ru("t")
+			d.Timeout = &api.UpstreamTimeout{Connect: &v}
+			if err := s.validateUpstreamRefs(&[]api.ReusableUpstream{d}, api.Upstream{}, nil); err == nil {
+				t.Errorf("expected error for non-canonical timeout.connect unit %q", v)
+			}
+		}
+	})
 	t.Run("no refs and no defs is valid", func(t *testing.T) {
 		if err := s.validateUpstreamRefs(nil, api.Upstream{}, nil); err != nil {
 			t.Errorf("expected nil, got %v", err)

platform-api/src/resources/openapi.yaml

@@ -6556,7 +6556,7 @@ components:
               weight:
                 type: integer
                 description: Weight for load balancing (optional, default 100)
-                minimum: 1
+                minimum: 0
                 maximum: 100
                 example: 80