Skip to content

Commit bc4fb65

Browse files
docs(gateway): clarify the controller wiring comment for the xDS paths
Describe the current wiring (only policy xDS receives the transformer registry; main Envoy xDS translates RestAPI configs directly) instead of implying the xDS translator cannot use transformers.
1 parent d085dc0 commit bc4fb65

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

  • gateway/gateway-controller/cmd/controller

gateway/gateway-controller/cmd/controller/main.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -390,11 +390,9 @@ func main() {
390390
llmTransformer := transform.NewLLMTransformer(configStore, db, &cfg.Router, cfg, policyDefinitions, policyVersionResolver)
391391
transformerRegistry := transform.NewRegistry(restTransformer, llmTransformer)
392392
policyManager.SetTransformers(transformerRegistry)
393-
// The policy manager receives the transformer registry; the snapshot
394-
// manager's xDS translator does not. The main xDS flow therefore uses
395-
// translateAPIConfig directly, while RuntimeDeployConfig output is
396-
// consumed only by the policy xDS flow. Both flows derive the same
397-
// cluster names.
393+
// In this controller wiring, only policy xDS receives the transformer
394+
// registry. Main Envoy xDS still translates RestAPI configs directly, so
395+
// both paths must keep cluster-name derivation in sync.
398396

399397
// Load runtime configs from existing API configurations on startup.
400398
// We write directly to runtimeStore to avoid triggering N separate snapshot updates;

0 commit comments

Comments
 (0)