update go and dependency versions#1825
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (25)
✅ Files skipped from review due to trivial changes (25)
📝 WalkthroughWalkthroughThis PR standardizes the repository on Go 1.26.2 by updating 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
gateway/it/go.mod (1)
184-193: Consider aligning OpenTelemetry exporter module versions for consistency.Lines 184, 187–188, 190–193 use OTel core modules at
v1.41.0, but three OTLP exporter modules remain atv1.35.0(lines 185–186: metric exporters; line 189: trace HTTP exporter). Aligning these exporter versions simplifies maintenance and reduces the risk of integration drift within the OTel dependency family.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@gateway/it/go.mod` around lines 184 - 193, The OTLP exporter modules otlpmetricgrpc (go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc), otlpmetrichttp (go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp) and otlptracehttp (go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp) are pinned at v1.35.0 while core OTel modules use v1.41.0; update those three exporter entries in go.mod to v1.41.0 so all listed OpenTelemetry modules align to v1.41.0 for consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@gateway/it/go.mod`:
- Around line 184-193: The OTLP exporter modules otlpmetricgrpc
(go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc),
otlpmetrichttp
(go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp) and
otlptracehttp (go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp)
are pinned at v1.35.0 while core OTel modules use v1.41.0; update those three
exporter entries in go.mod to v1.41.0 so all listed OpenTelemetry modules align
to v1.41.0 for consistency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bfdeb5fa-7a3d-42f9-b0d0-96e4c0463602
⛔ Files ignored due to path filters (13)
cli/it/go.sumis excluded by!**/*.sumcommon/go.sumis excluded by!**/*.sumevent-gateway/gateway-runtime/go.sumis excluded by!**/*.sumgateway/gateway-controller/go.sumis excluded by!**/*.sumgateway/gateway-runtime/policy-engine/go.sumis excluded by!**/*.sumgateway/it/go.sumis excluded by!**/*.sumgateway/system-policies/analytics/go.sumis excluded by!**/*.sumgo.workis excluded by!**/*.workgo.work.sumis excluded by!**/*.sumkubernetes/gateway-operator/go.sumis excluded by!**/*.sumplatform-api/src/go.sumis excluded by!**/*.sumsdk/ai/go.sumis excluded by!**/*.sumtests/mock-servers/mock-platform-api/go.sumis excluded by!**/*.sum
📒 Files selected for processing (27)
cli/it/go.modcli/src/go.modcommon/go.modevent-gateway/gateway-runtime/Dockerfileevent-gateway/gateway-runtime/go.modevent-gateway/webhook-listener/Dockerfileevent-gateway/webhook-listener/go.modgateway/gateway-builder/Dockerfilegateway/gateway-builder/go.modgateway/gateway-controller/Dockerfilegateway/gateway-controller/go.modgateway/gateway-runtime/Dockerfilegateway/gateway-runtime/policy-engine/go.modgateway/it/go.modgateway/sample-policies/transform-payload-case/go.modgateway/system-policies/analytics/go.modkubernetes/gateway-operator/go.modplatform-api/src/go.modsamples/sample-service/go.modsdk/ai/go.modsdk/core/go.modtests/mock-servers/mock-analytics-collector/go.modtests/mock-servers/mock-aws-bedrock-guardrail/go.modtests/mock-servers/mock-azure-content-safety/go.modtests/mock-servers/mock-embedding-provider/go.modtests/mock-servers/mock-jwks/go.modtests/mock-servers/mock-platform-api/go.mod
5fc84e1 to
cfad3a5
Compare
update go and dependency versions