Implement https support in request and bench actions

Author: bukka

TODO.md

@@ -49,9 +49,6 @@ in the future.
 
 #### Structure - Instances, Actions, Servers, Services
 
-- extend environment and request action to support TLS certificate
-  - environment publicUrl should support https - currently it is hard coded to return http so it should allow extra param to select it
-  - extend request action with a protocol option to select between http and https
 - http/2 requests
   - add http_version field to the request action
   - update the client to allow using http/2
@@ -156,7 +153,6 @@ in the future.
 
 #### Local environment
 
-- implement https publicUrl support
 - look into issues with orphaned children which happen when a task main process dies suddenly
   - find a way to get them somehow killed so it doesn't require manual clean up/
 - consider reporting closing output streams in Destroy
@@ -170,7 +166,6 @@ in the future.
 - support exec
 - implement storing and handling certificates
   - this should go to secrets from rendered certificates
-- implement https publicUrl support
 - allow setting default kubeconfig to ~/.kube/config (will require home dir support)
 - support and test native hook start where command is nil (set better executable - ideally configurable)
 - add health probes setup
@@ -183,7 +178,6 @@ in the future.
 - support exec
 - implement storing and handling certificates
   - this is currently done using bind so check if there is a better (more secure) way to do it for private keye
-- implement https publicUrl support
 - health check - waiting for container to be able to serve the traffic
 - custom docker
 

conf/parser/parser_test.go

@@ -2056,6 +2056,7 @@ func Test_ConfigParser_ParseConfig(t *testing.T) {
 									When:       "on_success",
 									OnFailure:  "fail",
 									Id:         "last",
+									Scheme:     "http",
 									Path:       "/api/status",
 									EncodePath: true,
 									Method:     "GET",

conf/types/action.go

@@ -114,6 +114,7 @@ type RequestAction struct {
 	When       string  `wst:"when,enum=always|on_success|on_failure,default=on_success"`
 	OnFailure  string  `wst:"on_failure,enum=fail|ignore|skip,default=fail"`
 	Id         string  `wst:"id,default=last"`
+	Scheme     string  `wst:"scheme,enum=http|https,default=http"`
 	Path       string  `wst:"path"`
 	EncodePath bool    `wst:"encode_path,default=true"`
 	Method     string  `wst:"method,enum=GET|HEAD|DELETE|POST|PUT|PATCH|PURGE,default=GET"`
@@ -126,6 +127,7 @@ type BenchAction struct {
 	When      string  `wst:"when,enum=always|on_success|on_failure,default=on_success"`
 	OnFailure string  `wst:"on_failure,enum=fail|ignore|skip,default=fail"`
 	Id        string  `wst:"id,default=last"`
+	Scheme    string  `wst:"scheme,enum=http|https,default=http"`
 	Path      string  `wst:"path"`
 	Method    string  `wst:"method,enum=GET|HEAD|DELETE|POST|PUT|PATCH|PURGE,default=GET"`
 	Headers   Headers `wst:"headers"`

mocks/generated/run/environments/task/mock_Task.go

@@ -79,6 +79,7 @@ func (m *ActionMaker) Make(
 		onFailure: action.OnFailureType(config.OnFailure),
 		freq:      config.Frequency,
 		id:        config.Id,
+		scheme:    config.Scheme,
 		path:      config.Path,
 		method:    config.Method,
 		headers:   config.Headers,
@@ -94,6 +95,7 @@ type Action struct {
 	duration  time.Duration
 	freq      int
 	id        string
+	scheme    string
 	path      string
 	method    string
 	headers   types.Headers
@@ -113,7 +115,7 @@ func (a *Action) Timeout() time.Duration {
 
 func (a *Action) Execute(ctx context.Context, runData runtime.Data) (bool, error) {
 	a.fnd.Logger().Infof("Executing bench action")
-	url, err := a.service.PublicUrl(a.path)
+	url, err := a.service.PublicUrl(a.scheme, a.path)
 	if err != nil {
 		return false, err
 	}