URLcheck: redact password in UI#2072
Open
huyz wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the URLcheck module UI to avoid displaying Basic Auth passwords by rendering a redacted URL string instead of the raw configured URL.
Changes:
- Render
urlResult.DisplayURL()in the URLcheck view instead of the rawUrlfield. - Add
DisplayURL()helper onurlResultto redact Basic Auth passwords via URL parsing. - Add unit tests covering redaction behavior across multiple URL forms (no auth, username only, username+password, encoded credentials, invalid URL).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/urlcheck/view.go | Switches template rendering from .Url to .DisplayURL so the UI shows a redacted URL when credentials are present. |
| modules/urlcheck/urlResult.go | Adds DisplayURL() helper to parse URLs and replace Basic Auth passwords with a placeholder. |
| modules/urlcheck/urlResult_test.go | Adds focused unit tests validating password redaction and ensuring the original Url field remains unchanged. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes URLs need a password for basic authentication; in these cases, we want to redact the password in the UI