Skip to content

URLcheck: redact password in UI#2072

Open
huyz wants to merge 2 commits into
wtfutil:trunkfrom
huyz:feature/urlcheck-redact-password
Open

URLcheck: redact password in UI#2072
huyz wants to merge 2 commits into
wtfutil:trunkfrom
huyz:feature/urlcheck-redact-password

Conversation

@huyz
Copy link
Copy Markdown
Contributor

@huyz huyz commented May 7, 2026

Sometimes URLs need a password for basic authentication; in these cases, we want to redact the password in the UI

Copilot AI review requested due to automatic review settings May 7, 2026 01:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the URLcheck module UI to avoid displaying Basic Auth passwords by rendering a redacted URL string instead of the raw configured URL.

Changes:

  • Render urlResult.DisplayURL() in the URLcheck view instead of the raw Url field.
  • Add DisplayURL() helper on urlResult to redact Basic Auth passwords via URL parsing.
  • Add unit tests covering redaction behavior across multiple URL forms (no auth, username only, username+password, encoded credentials, invalid URL).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
modules/urlcheck/view.go Switches template rendering from .Url to .DisplayURL so the UI shows a redacted URL when credentials are present.
modules/urlcheck/urlResult.go Adds DisplayURL() helper to parse URLs and replace Basic Auth passwords with a placeholder.
modules/urlcheck/urlResult_test.go Adds focused unit tests validating password redaction and ensuring the original Url field remains unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/urlcheck/urlResult.go Outdated
Comment thread modules/urlcheck/urlResult.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants