added local type#18
Conversation
| { | ||
| "name": "aem", | ||
| "version": "0.1.2-alpha.1718453175+e73fab23", | ||
| "version": "0.1.2-alpha.1718453293+5c68305a.dirty", |
|
|
||
| func (ic *InstanceClient) configureService() error { | ||
| if !ic.data.System.ServiceEnabled || ic.data.Client.Type == "local" { | ||
| if !ic.data.System.ServiceEnabled { |
There was a problem hiding this comment.
I don't remeber such bool serviceEnabled in TF provider... why have you introduced it? these providers should not be so different
There was a problem hiding this comment.
system service is must have; we want to maintain only the single and correct way of setting up AEM instances... maintaining variations will increase complexity
There was a problem hiding this comment.
hmm if serviceEnabled = false then runServiceCommand("start") need be replaced by "sh aemw instance launch" command and the similar thing for stopping
There was a problem hiding this comment.
for non-admin usages like on local/dev machine it would be fine
| @@ -102,6 +102,7 @@ type System struct { | |||
| WorkDir string `pulumi:"work_dir,optional"` | |||
| Env map[string]string `pulumi:"env,optional"` | |||
| ServiceEnabled bool `pulumi:"service_enabled,optional"` | |||
| @@ -55,6 +59,8 @@ private System( | |||
|
|
|||
| bool? service_enabled, | |||
krystian-panek-vmltech
left a comment
krystian-panek-vmltech
left a comment
There was a problem hiding this comment.
serviceEnabled / system service is must-have, not an optional thing
| System: compose.SystemArgs{ | ||
| Data_dir: pulumi.String(composeDir), | ||
| Work_dir: pulumi.String(workDir), | ||
| Service_enabled: pulumi.Bool(false), |
There was a problem hiding this comment.
I don't want to have ServiceEnabled here
krystian-panek-vmltech
left a comment
krystian-panek-vmltech
left a comment
There was a problem hiding this comment.
if systemd is optional then starting/stopping instance need to be aligned
2 participants
No description provided.