Issues/82 add test integration 2#85
Open
marek-ch wants to merge 24 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the first integration test suite for the networking library (closes #82) and, as part of the same change, renames the public EndpointSigned / EndpointSignedWithToken types and the surrounding documentation/terminology to use "authenticated" instead of "signed". Old type names are retained as deprecated typealiases to preserve binary/source compatibility.
Changes:
- New
androidTestmodule:PostMockWebServerTest(offline) andPostRealServerTest(server-backed), plus support classes (PowerAuthIntegrationProxy,IntegrationTestApi,TestConfiguration,TestEndpoints) and config asset scaffolding. - New GitHub Actions workflow
.github/workflows/tests.ymlrunning unit tests and emulator-based integration tests, plus ascripts/test.shdriver. - Rename
EndpointSigned/EndpointSignedWithToken→EndpointAuthenticated/EndpointAuthenticatedWithToken(with@Deprecatedtypealiases), updatedApi.ktoverloads, README, copilot instructions, and existing unit tests; missing Apache headers added toWPNLogger/WPNLogListener.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/copilot-instructions.md | Reflects the EndpointAuthenticated* rename in repo guidance. |
| .github/workflows/tests.yml | New CI workflow running unit + integration (emulator) tests; uses TESTS_CONFIG secret. |
| README.md | Renames terminology from "signed" to "authenticated" throughout the public docs. |
| library/src/main/java/com/wultra/android/powerauth/networking/Api.kt | Updates post() overloads to new endpoint type names and tweaks KDoc. |
| library/src/main/java/com/wultra/android/powerauth/networking/Endpoint.kt | Renames endpoint classes and adds deprecated typealiases for the old names. |
| library/src/main/java/com/wultra/android/powerauth/networking/log/WPNLogger.kt | Adds missing Apache license header. |
| library/src/main/java/com/wultra/android/powerauth/networking/log/WPNLogListener.kt | Adds missing Apache license header. |
| library/src/test/.../{BaseNetworkingObjectsTest,GsonConverterTest,SSLValidationStrategyTest,UserAgentTest}.kt | Drops "Mirrors Apple's …" comments. |
| library/src/test/.../EndpointTest.kt | Updates tests to the new EndpointAuthenticated* names. |
| library/src/androidTest/.../PostMockWebServerTest.kt | Adds offline HTTP pipeline tests via MockWebServer. |
| library/src/androidTest/.../PostRealServerTest.kt | Adds server-dependent tests (skipped when config.json missing) and a JSONPlaceholder transport test. |
| library/src/androidTest/.../support/PowerAuthIntegrationProxy.kt | Helper that drives the full activation lifecycle against PowerAuth Cloud. |
| library/src/androidTest/.../support/IntegrationTestApi.kt | Thin Api subclass used by integration tests. |
| library/src/androidTest/.../support/TestConfiguration.kt | Gson-loaded test config from assets/config.json. |
| library/src/androidTest/.../support/TestEndpoints.kt | Pre-defined endpoint constants shared between integration tests. |
| library/src/androidTest/assets/README.md | Documents setup and schema of config.json. |
| library/src/androidTest/assets/config-example.json | Template for the (git-ignored) integration test config. |
| scripts/test.sh | Driver script invoked by CI; writes config and runs unit or instrumentation tests. |
86c44ff to
1e84aaa
Compare
Agent-Logs-Url: https://github.com/wultra/networking-android/sessions/f38f7517-361e-485e-8a24-d35081d5a40f Co-authored-by: marek-ch <193891501+marek-ch@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82