Skip to content

Issues/82 add test integration 2#85

Open
marek-ch wants to merge 24 commits into
developfrom
issues/82-add-test-integration-2
Open

Issues/82 add test integration 2#85
marek-ch wants to merge 24 commits into
developfrom
issues/82-add-test-integration-2

Conversation

@marek-ch
Copy link
Copy Markdown
Contributor

Closes #82

@marek-ch marek-ch self-assigned this May 18, 2026
Copilot AI review requested due to automatic review settings May 18, 2026 10:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the first integration test suite for the networking library (closes #82) and, as part of the same change, renames the public EndpointSigned / EndpointSignedWithToken types and the surrounding documentation/terminology to use "authenticated" instead of "signed". Old type names are retained as deprecated typealiases to preserve binary/source compatibility.

Changes:

  • New androidTest module: PostMockWebServerTest (offline) and PostRealServerTest (server-backed), plus support classes (PowerAuthIntegrationProxy, IntegrationTestApi, TestConfiguration, TestEndpoints) and config asset scaffolding.
  • New GitHub Actions workflow .github/workflows/tests.yml running unit tests and emulator-based integration tests, plus a scripts/test.sh driver.
  • Rename EndpointSigned/EndpointSignedWithTokenEndpointAuthenticated/EndpointAuthenticatedWithToken (with @Deprecated typealiases), updated Api.kt overloads, README, copilot instructions, and existing unit tests; missing Apache headers added to WPNLogger/WPNLogListener.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 19 comments.

Show a summary per file
File Description
.github/copilot-instructions.md Reflects the EndpointAuthenticated* rename in repo guidance.
.github/workflows/tests.yml New CI workflow running unit + integration (emulator) tests; uses TESTS_CONFIG secret.
README.md Renames terminology from "signed" to "authenticated" throughout the public docs.
library/src/main/java/com/wultra/android/powerauth/networking/Api.kt Updates post() overloads to new endpoint type names and tweaks KDoc.
library/src/main/java/com/wultra/android/powerauth/networking/Endpoint.kt Renames endpoint classes and adds deprecated typealiases for the old names.
library/src/main/java/com/wultra/android/powerauth/networking/log/WPNLogger.kt Adds missing Apache license header.
library/src/main/java/com/wultra/android/powerauth/networking/log/WPNLogListener.kt Adds missing Apache license header.
library/src/test/.../{BaseNetworkingObjectsTest,GsonConverterTest,SSLValidationStrategyTest,UserAgentTest}.kt Drops "Mirrors Apple's …" comments.
library/src/test/.../EndpointTest.kt Updates tests to the new EndpointAuthenticated* names.
library/src/androidTest/.../PostMockWebServerTest.kt Adds offline HTTP pipeline tests via MockWebServer.
library/src/androidTest/.../PostRealServerTest.kt Adds server-dependent tests (skipped when config.json missing) and a JSONPlaceholder transport test.
library/src/androidTest/.../support/PowerAuthIntegrationProxy.kt Helper that drives the full activation lifecycle against PowerAuth Cloud.
library/src/androidTest/.../support/IntegrationTestApi.kt Thin Api subclass used by integration tests.
library/src/androidTest/.../support/TestConfiguration.kt Gson-loaded test config from assets/config.json.
library/src/androidTest/.../support/TestEndpoints.kt Pre-defined endpoint constants shared between integration tests.
library/src/androidTest/assets/README.md Documents setup and schema of config.json.
library/src/androidTest/assets/config-example.json Template for the (git-ignored) integration test config.
scripts/test.sh Driver script invoked by CI; writes config and runs unit or instrumentation tests.

Comment thread library/src/main/java/com/wultra/android/powerauth/networking/Endpoint.kt Outdated
Comment thread library/src/androidTest/assets/config-example.json
@marek-ch marek-ch force-pushed the issues/82-add-test-integration-2 branch 2 times, most recently from 86c44ff to 1e84aaa Compare May 18, 2026 11:17
@marek-ch
Copy link
Copy Markdown
Contributor Author

@kober32 sorry for new PR, but I have taken commits from previous one..
You can start review from a1c3e25
(or 8 last commits) Thanks

Copy link
Copy Markdown

Copilot AI commented May 18, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx1536m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.14.4-bin/92wwslzcyst3phie3o264zltu/gradle-8.14.4/lib/gradle-daemon-main-8.14.4.jar (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests - integration

3 participants