Skip to content

fix(router): proto.Reset stale execution config after manifest reload#3013

Open
arutkowski00 wants to merge 1 commit into
wundergraph:mainfrom
mondaycom:adamru/upstream-bugfix-proto-reset-execution-config
Open

fix(router): proto.Reset stale execution config after manifest reload#3013
arutkowski00 wants to merge 1 commit into
wundergraph:mainfrom
mondaycom:adamru/upstream-bugfix-proto-reset-execution-config

Conversation

@arutkowski00

Copy link
Copy Markdown

Problem

After manifest hot-reload, decoded proto strings from the previous staticExecutionConfig could remain retained even after the new config was assembled.

Fix

After a successful manifest reload, proto.Reset the previous config before retaining the new pointer.

Test plan

  • go test ./router/core/...

Part of config hot-reload memory leak investigation (monday.com #3221).

After a successful manifest hot-reload, release decoded proto strings
from the previous staticExecutionConfig with proto.Reset before
retaining the new config pointer.
@arutkowski00 arutkowski00 requested a review from a team as a code owner June 24, 2026 21:13
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@arutkowski00, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 23 minutes and 43 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 65c3117e-db20-49fd-a3a9-7706f5ebdaa8

📥 Commits

Reviewing files that changed from the base of the PR and between 7b40f14 and 4c106e7.

📒 Files selected for processing (1)
  • router/core/router.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.08%. Comparing base (7b40f14) to head (4c106e7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3013      +/-   ##
==========================================
- Coverage   61.42%   54.08%   -7.35%     
==========================================
  Files         259      243      -16     
  Lines       30046    29469     -577     
==========================================
- Hits        18455    15937    -2518     
- Misses      10104    11950    +1846     
- Partials     1487     1582      +95     
Files with missing lines Coverage Δ
router/core/router.go 69.36% <100.00%> (-1.12%) ⬇️

... and 132 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant