fix(router): proto.Reset stale execution config after manifest reload#3013
Conversation
After a successful manifest hot-reload, release decoded proto strings from the previous staticExecutionConfig with proto.Reset before retaining the new config pointer.
|
Warning Review limit reached
More reviews will be available in 23 minutes and 43 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3013 +/- ##
==========================================
- Coverage 61.42% 54.08% -7.35%
==========================================
Files 259 243 -16
Lines 30046 29469 -577
==========================================
- Hits 18455 15937 -2518
- Misses 10104 11950 +1846
- Partials 1487 1582 +95
🚀 New features to boost your workflow:
|
Problem
After manifest hot-reload, decoded proto strings from the previous
staticExecutionConfigcould remain retained even after the new config was assembled.Fix
After a successful manifest reload,
proto.Resetthe previous config before retaining the new pointer.Test plan
go test ./router/core/...Part of config hot-reload memory leak investigation (monday.com #3221).