perf(grpc_datasource): experiments with claude#1469
Draft
jensneuse wants to merge 1 commit into
Draft
Conversation
…lback Introduces DataSourceV2 — a compiled-IR gRPC datasource that processes supported query shapes through a flat index-based response frame with zero astjson round-trip, delegating unsupported shapes to V1. Alongside, this branch contains nine phases of V1 optimizations (DependencyGraph pool, jsonBuilder pool, arena reuse, pre-computed method names, etc.) and the loader-side Value-returning DataSource refactor that both V1 and V2 benefit from. Key changes: - New V2 stack: v2_ir / v2_compile / v2_runtime / v2_frame / v2_schema - Dual-backend schema runtime (generated proto + dynamicpb + hyperpb precompiled for reads) - Fallback-with-reasons pattern: shapes outside MVP route to V1 - Paired V1/V2 parity tests + robustness test across federation shapes - Loader refactor: DataSource returns *astjson.Value directly, skipping serialize/reparse round-trip - V1 cleanup: removed hyperpb integration after benchmarks showed V2 dynamicpb (231 allocs) beats V1+hyperpb (266 allocs) - Deleted marshalplan.go, hyperpb_codec.go, and related dead code Current V2 native coverage: CallKindStandard with no deps, CallKindResolve with exactly one dep. CallKindEntity falls back pending _entities array-merge across calls. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a random experiment to see what claude would optimize to get a feeling for what could be optimized.