Skip to content

feat: bypass null subscription filter values#1484

Draft
jensneuse wants to merge 3 commits into
masterfrom
feat/subscription-filter-bypass-null-values
Draft

feat: bypass null subscription filter values#1484
jensneuse wants to merge 3 commits into
masterfrom
feat/subscription-filter-bypass-null-values

Conversation

@jensneuse

Copy link
Copy Markdown
Member

Summary

  • Add BypassIfValuesNull to subscription field filter config and runtime filter structs.
  • Propagate the flag through the planner into resolve filters.
  • Treat single-segment templated IN values resolving to nil or GraphQL null as a filter match before event payload lookup.

Test Plan

  • cd v2 && go test ./pkg/engine/...

@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e0421d11-92b0-4c46-99db-2aad73568936

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/subscription-filter-bypass-null-values

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant