feat: expose concurrency limits and inflight resolves#1501
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds two exported Resolver methods exposing semaphore capacity and in-flight resolves, and instruments GraphQLResolveInfo with timestamps and durations for the resolve/render and client-write phases; instrumentation is applied in both normal and singleflight response paths. ChangesResolver Concurrency & Timing
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…okup-timeout-impacting-wundergraph-router-latency
…okup-timeout-impacting-wundergraph-router-latency
…okup-timeout-impacting-wundergraph-router-latency
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@v2/pkg/engine/resolve/resolve.go`:
- Around line 390-394: The current path sets resp.ResponseResolveStartTime and
resp.ResponseResolveDuration after calling t.resolvable.Resolve but leaves
resp.ResponseWriteStartTime and resp.ResponseWriteDuration zero; update
ResolveGraphQLResponse so that immediately after computing responseResolveStart
and resp.ResponseResolveDuration you also set resp.ResponseWriteStartTime =
responseResolveStart and resp.ResponseWriteDuration =
resp.ResponseResolveDuration (or compute a separate duration using
time.Since(responseResolveStart) for clarity) so GraphQLResolveInfo is populated
consistently; locate this in the block around t.resolvable.Resolve,
resp.ResponseResolveStartTime, and resp.ResponseResolveDuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b046cc6c-2fc7-4370-bfa2-0efca5033b7b
📒 Files selected for processing (1)
v2/pkg/engine/resolve/resolve.go
…wundergraph-router-latency
…okup-timeout-impacting-wundergraph-router-latency
…wundergraph-router-latency
…okup-timeout-impacting-wundergraph-router-latency
…okup-timeout-impacting-wundergraph-router-latency
…okup-timeout-impacting-wundergraph-router-latency
…okup-timeout-impacting-wundergraph-router-latency
…wundergraph-router-latency
🤖 I have created a release *beep* *boop* --- ## [2.7.0](v2.6.0...v2.7.0) (2026-07-02) ### Features * expose concurrency limits and inflight resolves ([#1501](#1501)) ([c9af890](c9af890)) ### Bug Fixes * fix provides on abstract types ([#1564](#1564)) ([8244558](8244558)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: wundergraph-bot[bot] <285992168+wundergraph-bot[bot]@users.noreply.github.com>
@coderabbitai summary
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.