Fixed when <library>true</library> specified in inclusions/inclusion,…#80
Open
lexchou wants to merge 2 commits into
Open
Fixed when <library>true</library> specified in inclusions/inclusion,…#80lexchou wants to merge 2 commits into
lexchou wants to merge 2 commits into
Conversation
… the filter was ignored
lasselindqvist
requested changes
May 14, 2019
Collaborator
lasselindqvist
left a comment
lasselindqvist
left a comment
There was a problem hiding this comment.
The indendation is funny. It seems that you are using spaces instead of tabs.
Also, would it be better for the lines 457-466 be next to the line 481?
Collaborator
|
I resolved the conflicts for this. @lexchou can you confirm that they went as intended? |
Collaborator
|
Also needs conflicts to be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… the filter was ignored