chore: remove node-fetch in favor of Node.js 18+ built-in fetch#201796
Open
beenotung wants to merge 2 commits into
Open
chore: remove node-fetch in favor of Node.js 18+ built-in fetch#201796beenotung wants to merge 2 commits into
beenotung wants to merge 2 commits into
Conversation
github-actions
Bot
added
dependencies
beenotung
force-pushed
the
chore/remove-node-fetch
branch
from
a9f5732 to
4f8f9c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 18+ provides a built-in fetch API, and since this project requires Node.js >=18.0.0, the node-fetch dependency is no longer necessary.
Changes
Notes
The existing code in MessageMedia.js already handles native fetch via the arrayBuffer() fallback when response.buffer is unavailable.