Skip to content

Commit 07a4ba8

Browse files
fix: Make ExtensionRunner#closeBrowser optional (#2092)
Co-authored-by: Patryk Kuniczak <p.kuniczak@gmail.com>
1 parent f84921f commit 07a4ba8

5 files changed

Lines changed: 5 additions & 12 deletions

File tree

packages/wxt/src/core/create-server.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ async function createServerInternal(): Promise<WxtDevServer> {
126126
async stop() {
127127
wasStopped = true;
128128
keyboardShortcuts.stop();
129-
await runner.closeBrowser();
129+
await runner.closeBrowser?.();
130130
await builderServer.close();
131131
await wxt.hooks.callHook('server:closed', wxt, server);
132132

@@ -150,7 +150,7 @@ async function createServerInternal(): Promise<WxtDevServer> {
150150
server.ws.send('wxt:reload-extension');
151151
},
152152
async restartBrowser() {
153-
await runner.closeBrowser();
153+
await runner.closeBrowser?.();
154154
keyboardShortcuts.stop();
155155
await wxt.reloadConfig();
156156
runner = await createExtensionRunner();

packages/wxt/src/core/runners/manual.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,5 @@ export function createManualRunner(): ExtensionRunner {
1515
)}" as an unpacked extension manually`,
1616
);
1717
},
18-
async closeBrowser() {
19-
// noop
20-
},
2118
};
2219
}

packages/wxt/src/core/runners/safari.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,5 @@ export function createSafariRunner(): ExtensionRunner {
1515
)}" as an unpacked extension manually`,
1616
);
1717
},
18-
async closeBrowser() {
19-
// noop
20-
},
2118
};
2219
}

packages/wxt/src/core/runners/wsl.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,5 @@ export function createWslRunner(): ExtensionRunner {
1515
)}" as an unpacked extension manually`,
1616
);
1717
},
18-
async closeBrowser() {
19-
// noop
20-
},
2118
};
2219
}

packages/wxt/src/types.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1428,7 +1428,9 @@ export interface FsCache {
14281428

14291429
export interface ExtensionRunner {
14301430
openBrowser(): Promise<void>;
1431-
closeBrowser(): Promise<void>;
1431+
1432+
closeBrowser?(): Promise<void>;
1433+
14321434
/** Whether or not this runner actually opens the browser. */
14331435
canOpen?(): boolean;
14341436
}

0 commit comments

Comments
 (0)