Skip to content

feat: Add warning for missing Firefox extension ID in manifest #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sbrjt wants to merge 4 commits into
base: main
Choose a base branch
from
+20 −1
Open

feat: Add warning for missing Firefox extension ID in manifest #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fddf85
fix: add warning for missing Firefox extension ID in manifest
Sbrjt Apr 23, 2026
4f4742b
fix: remove unnecessary blank lines
Sbrjt Apr 25, 2026
6f254a6
fix: add suppressWarnings option for missing Firefox extension ID
Sbrjt Apr 28, 2026
fcdf819
Merge branch 'main' into main
PatrykKuniczak Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/wxt/src/core/utils/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,17 @@ export async function generateManifest(
);
}

if (
wxt.config.browser === 'firefox' &&
!manifest.browser_specific_settings?.gecko?.id &&
!wxt.config.suppressWarnings?.firefoxId
) {
wxt.logger.warn(
'Firefox requires extension ID for MV3 and recommends it for MV2.\n' +
'For more details, see: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings#id',
);
}

addEntrypoints(manifest, entrypoints, buildOutput);

if (wxt.config.browser === 'firefox') {
Expand Down
10 changes: 9 additions & 1 deletion packages/wxt/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@ export interface InlineConfig {
* https://extensionworkshop.com/documentation/develop/firefox-builtin-data-consent
*/
firefoxDataCollection?: boolean;
/**
* Suppress warnings when the Firefox extension ID is missing.
* https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings#id
*/
firefoxId?: boolean;
};
/**
* Configure browser startup. Options set here can be overridden in a
Expand Down Expand Up @@ -1514,7 +1519,10 @@ export interface ResolvedConfig {
alias: Record<string, string>;
experimental: {};
/** List of warning identifiers to suppress during the build process. */
suppressWarnings: { firefoxDataCollection?: boolean };
suppressWarnings: {
firefoxDataCollection?: boolean;
firefoxId?: boolean;
};
dev: {
/** Only defined during dev command */
server?: {
Expand Down