feat!: Change default behavior of getUnimportEslintOptions true flag#2296
Open
PatrykKuniczak wants to merge 8 commits intowxt-dev:mainfrom
Open
feat!: Change default behavior of getUnimportEslintOptions true flag#2296PatrykKuniczak wants to merge 8 commits intowxt-dev:mainfrom
getUnimportEslintOptions true flag#2296PatrykKuniczak wants to merge 8 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
=======================================
Coverage 79.73% 79.73%
=======================================
Files 131 131
Lines 3804 3804
Branches 861 861
=======================================
Hits 3033 3033
Misses 686 686
Partials 85 85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aklinker1
requested changes
Apr 26, 2026
Collaborator
Author
|
@aklinker1 There's no diffs, what i'm supposed to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changed behavior of
getUnimportEslintOptionsto be current version ofeslintfrompackage.jsonontrueflag.I hope this change is good, i think it's more meaningful to have latest version on
truemost of packages works like this.If you enabling sth, you expect the latest version of that package.
IMO it has sense.
Manual Testing
Let's see if tests passed