Skip to content

feat!: Change default behavior of getUnimportEslintOptions true flag#2296

Open
PatrykKuniczak wants to merge 8 commits intowxt-dev:mainfrom
PatrykKuniczak:feat/change-default-unimport-eslint-behaviour
Open

feat!: Change default behavior of getUnimportEslintOptions true flag#2296
PatrykKuniczak wants to merge 8 commits intowxt-dev:mainfrom
PatrykKuniczak:feat/change-default-unimport-eslint-behaviour

Conversation

@PatrykKuniczak
Copy link
Copy Markdown
Collaborator

Overview

Changed behavior of getUnimportEslintOptions to be current version of eslint from package.json on true flag.

I hope this change is good, i think it's more meaningful to have latest version on true most of packages works like this.
If you enabling sth, you expect the latest version of that package.
IMO it has sense.

Manual Testing

Let's see if tests passed

@PatrykKuniczak PatrykKuniczak self-assigned this Apr 24, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 0540f76
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69efb5967e363500084c736b
😎 Deploy Preview https://deploy-preview-2296--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Apr 24, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 24, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2296

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2296

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2296

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2296

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2296

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2296

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2296

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2296

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2296

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2296

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2296

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2296

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2296

wxt

npm i https://pkg.pr.new/wxt@2296

commit: 0540f76

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.73%. Comparing base (e75e534) to head (0540f76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2296   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files         131      131           
  Lines        3804     3804           
  Branches      861      861           
=======================================
  Hits         3033     3033           
  Misses        686      686           
  Partials       85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the diffs then I'll re-review. I'm OK with this change.

@PatrykKuniczak
Copy link
Copy Markdown
Collaborator Author

@aklinker1 There's no diffs, what i'm supposed to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants