chore: Change wxt-demo eslint extension#2298
Draft
PatrykKuniczak wants to merge 2 commits intowxt-dev:mainfrom
Draft
chore: Change wxt-demo eslint extension#2298PatrykKuniczak wants to merge 2 commits intowxt-dev:mainfrom
wxt-demo eslint extension#2298PatrykKuniczak wants to merge 2 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 79.74% 79.69% -0.06%
==========================================
Files 130 130
Lines 3802 3802
Branches 860 860
==========================================
- Hits 3032 3030 -2
- Misses 686 688 +2
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
How do I test this? |
Collaborator
Author
|
@aklinker1 let's pull those changes and see there's error like in #1981 and then #2297 needs to be merged or you can cherry-pick those changes and then see, there's no error for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changed to show #2297 works well and have one more place with
.ts, with that we can be closer to fully.tssupport on project.Blocked by #2297
Manual Testing
Let's check if tests pass and see in IDE if there's no error
Related Issue
#1981