Skip to content

fix(browser): add IOS to PlatformOs enum#2308

Closed
rxliuli wants to merge 1 commit intowxt-dev:mainfrom
rxliuli:fix/add-ios-platform-os
Closed

fix(browser): add IOS to PlatformOs enum#2308
rxliuli wants to merge 1 commit intowxt-dev:mainfrom
rxliuli:fix/add-ios-platform-os

Conversation

@rxliuli
Copy link
Copy Markdown
Contributor

@rxliuli rxliuli commented Apr 27, 2026

Summary

  • Add IOS = "ios" to Runtime.PlatformOs enum in @wxt-dev/browser type definitions
  • Safari on iOS/iPadOS reports runtime.getPlatformInfo().os as "ios", but the type was missing this value, causing TypeScript errors when comparing against it

Reference

🤖 Generated with Claude Code

Safari on iOS/iPadOS reports `runtime.getPlatformInfo().os` as `"ios"`,
but the type definition was missing this value, causing TypeScript errors
when comparing against it.

Ref: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/PlatformOs#ios

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rxliuli rxliuli requested a review from aklinker1 as a code owner April 27, 2026 02:43
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 27, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 12a0bb2
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69eecd41c8a2bb000701a97b
😎 Deploy Preview https://deploy-preview-2308--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the pkg/browser Includes changes to the `packages/browser` directory label Apr 27, 2026
@aklinker1
Copy link
Copy Markdown
Member

This package is generated based on @types/chrome, make your changes there instead.

@aklinker1 aklinker1 closed this Apr 27, 2026
@rxliuli
Copy link
Copy Markdown
Contributor Author

rxliuli commented Apr 27, 2026

This package is generated based on @types/chrome, make your changes there instead.

done. DefinitelyTyped/DefinitelyTyped#74923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/browser Includes changes to the `packages/browser` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants