chore: Keep lockfile in sync when generating @wxt-dev/browser#2310
Merged
chore: Keep lockfile in sync when generating @wxt-dev/browser#2310
@wxt-dev/browser#2310Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
pkg/browser
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2310 +/- ##
==========================================
+ Coverage 79.65% 79.83% +0.18%
==========================================
Files 131 131
Lines 3804 3804
Branches 861 861
==========================================
+ Hits 3030 3037 +7
+ Misses 690 684 -6
+ Partials 84 83 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Without the added line, the lockfile ends up out-of-sync... not sure why. But running a second install after the package is generated solves the out-of-sync lockfile.
I had a similar issue with the release workflow leaving the lockfile out-of-date after the bun migration. Running another install also resolved it in that case.
Manual Testing
Run it on
mainand you'll see an change in thebun.lockfile. Run it on this branch and it's all good.Related Issue
Replaces #2299