fix: exclude open_in_tab from options_ui for Safari#2311
Open
rxliuli wants to merge 3 commits intowxt-dev:mainfrom
Open
fix: exclude open_in_tab from options_ui for Safari#2311rxliuli wants to merge 3 commits intowxt-dev:mainfrom
rxliuli wants to merge 3 commits intowxt-dev:mainfrom
Conversation
Safari does not support the `open_in_tab` key in `options_ui`. Including it causes `safari-web-extension-converter` to emit a warning: "The following keys in your manifest.json are not supported by your current version of Safari: open_in_tab" This follows the same pattern used for `browser_style` (Firefox-only) and `chrome_style` (non-Firefox only). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
pkg/wxt
aklinker1
approved these changes
Apr 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
=======================================
Coverage 79.73% 79.73%
=======================================
Files 131 131
Lines 3804 3805 +1
Branches 861 862 +1
=======================================
+ Hits 3033 3034 +1
Misses 686 686
Partials 85 85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Member
|
Looks like you have some type errors: https://github.com/wxt-dev/wxt/actions/runs/24995402536/job/73196741505?pr=2311 |
- Use conditional spread instead of undefined assignment for open_in_tab to satisfy the boolean type constraint - Remove stale @ts-expect-error for browser_style (now typed upstream) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
ref cb2664d |
Lost when refactoring open_in_tab into a conditional spread for Safari. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Sorry, didn't run the check locally last time. Did it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open_in_tabkey inoptions_ui. Including it causessafari-web-extension-converterto emit a warning: "The following keys in your manifest.json are not supported by your current version of Safari: open_in_tab"open_in_tabtoundefinedwhen building for Safari, following the same pattern used forbrowser_style(Firefox-only) andchrome_style(non-Firefox only)Test plan
open_in_tabis excluded for Safariwxt build -b safarithat the output manifest no longer containsopen_in_tab