fix: clean removes .wxt directory at project root#2415
Open
LUIDevo wants to merge 1 commit into
Open
Conversation
`wxt clean` never deleted a `.wxt` directory located at the project
root. The `**/.wxt` glob requires at least one parent path segment in
tinyglobby, so only nested `.wxt` directories matched. Replace it with
`{,**/}.wxt`, which matches both root-level and nested `.wxt`.
Fixes wxt-dev#2413
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
pkg/wxt
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2415 +/- ##
==========================================
- Coverage 78.61% 78.41% -0.21%
==========================================
Files 133 133
Lines 3882 3882
Branches 875 875
==========================================
- Hits 3052 3044 -8
- Misses 743 750 +7
- Partials 87 88 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
wxt cleannever deleted a.wxtdirectory located at the project root. The**/.wxtline requires at least one parent path, so only nested.wxtdirectories matched. Replace it with{,**/}.wxt, which matches both root and nested.wxt.(The same result is achievable by adding
'.wxt'alongside'**/.wxt', but that takes an extra line.)Manual Testing
Create a directory '.wxt' in the project root. By running 'wxt clean', the .wxt directory gets deleted, along with any nested
.wxtdirectory. Before this change, the root '.wxt' directory would not be deleted, and now it does along with the other files.Related Issue
This PR closes #2413