Skip to content

fix: opening the browser issue in windows.#2436

Merged
aklinker1 merged 1 commit into
wxt-dev:mainfrom
nishu-murmu:fix/keyboard-shortcut-windows-issue
Jun 29, 2026
Merged

fix: opening the browser issue in windows.#2436
aklinker1 merged 1 commit into
wxt-dev:mainfrom
nishu-murmu:fix/keyboard-shortcut-windows-issue

Conversation

@nishu-murmu

Copy link
Copy Markdown
Collaborator

Overview

Problem: Press o + enter to reopen the browser doesn't work on Windows.

Fix: While opening the browser calling the start function was missed.

PS: I've checked it in Linux as well, it is working fine there too.
Finally this issue is fixed.

Manual Testing

  1. cd into packages/wxt-demo and run bun dev.
  2. Try different scenario for pressing o + Enter.

Related Issue

This PR closes #2294

WindowsTerminal_kJIp2MB2S5.online-video-cutter.com.mp4

@nishu-murmu nishu-murmu requested a review from aklinker1 as a code owner June 27, 2026 18:56
@netlify

netlify Bot commented Jun 27, 2026

Copy link
Copy Markdown

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 57c81e4
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6a401cd44fad000008fa889c
😎 Deploy Preview https://deploy-preview-2436--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Jun 27, 2026
@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

@nishu-murmu I like it, i'll check it tomorrow 😄

@aklinker1 aklinker1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🤞

@aklinker1 aklinker1 enabled auto-merge (squash) June 29, 2026 21:01
@pkg-pr-new

pkg-pr-new Bot commented Jun 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2436

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2436

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2436

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2436

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2436

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2436

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2436

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2436

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2436

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2436

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2436

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2436

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2436

wxt

npm i https://pkg.pr.new/wxt@2436

commit: 57c81e4

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.42%. Comparing base (42a5b3c) to head (57c81e4).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
packages/wxt/src/core/create-server.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2436      +/-   ##
==========================================
+ Coverage   78.41%   78.42%   +0.01%     
==========================================
  Files         133      133              
  Lines        3882     3884       +2     
  Branches      875      876       +1     
==========================================
+ Hits         3044     3046       +2     
  Misses        749      749              
  Partials       89       89              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aklinker1 aklinker1 merged commit f75d1e1 into wxt-dev:main Jun 29, 2026
19 of 20 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Press o + enter to reopen the browser doesn't work on Windows

3 participants