Skip to content

fix(qoder): install permission request hooks #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxtsky merged 1 commit into from
Jul 23, 2026
Merged

fix(qoder): install permission request hooks #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions Sources/CodeIsland/ConfigInstaller.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,12 +294,25 @@ struct ConfigInstaller {
format: .traecli,
events: defaultEvents(for: .traecli)
),
// Qoder — Claude Code fork
// Qoder — Claude Code fork with its own documented PermissionRequest hook.
CLIConfig(
name: "Qoder", source: "qoder",
configPath: ".qoder/settings.json", configKey: "hooks",
format: .claude,
events: defaultEvents(for: .claude)
events: [
("UserPromptSubmit", 5, true),
("PreToolUse", 5, false),
("PostToolUse", 5, true),
("PostToolUseFailure", 5, true),
("PermissionRequest", 86400, false),
("Stop", 5, true),
("SubagentStart", 5, true),
("SubagentStop", 5, true),
("SessionStart", 5, false),
("SessionEnd", 5, true),
("Notification", 86400, false),
("PreCompact", 5, true),
]
),
// QoderWork — Qoder's standalone desktop assistant app (not the IDE).
// Claude-format hooks, but user-level ~/.qoderwork/settings.json ONLY
Expand All @@ -309,7 +322,20 @@ struct ConfigInstaller {
name: "QoderWork", source: "qoderwork",
configPath: ".qoderwork/settings.json", configKey: "hooks",
format: .claude,
events: defaultEvents(for: .claude)
events: [
("UserPromptSubmit", 5, true),
("PreToolUse", 5, false),
("PostToolUse", 5, true),
("PostToolUseFailure", 5, true),
("PermissionRequest", 86400, false),
("Stop", 5, true),
("SubagentStart", 5, true),
("SubagentStop", 5, true),
("SessionStart", 5, false),
("SessionEnd", 5, true),
("Notification", 86400, false),
("PreCompact", 5, true),
]
),
// Factory — Claude Code fork (uses "droid" as source identifier)
CLIConfig(
Expand Down
10 changes: 10 additions & 0 deletions Tests/CodeIslandTests/ConfigInstallerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@ final class ConfigInstallerTests: XCTestCase {
let hooks = try XCTUnwrap(hooksAny as? [Any], file: file, line: line)
return hooks.compactMap { $0 as? [String: Any] }
}

func testQoderConfigIncludesPermissionRequestHook() throws {
let cli = try XCTUnwrap(ConfigInstaller.allCLIs.first { $0.source == "qoder" })
XCTAssertEqual(cli.format, .claude)
XCTAssertEqual(cli.configPath, ".qoder/settings.json")
let permission = try XCTUnwrap(cli.events.first { $0.0 == "PermissionRequest" })
XCTAssertEqual(permission.1, 86400)
XCTAssertFalse(permission.2)
}

func testRemoveManagedHookEntriesAlsoPrunesLegacyVibeIslandHooks() throws {
let hooks: [String: Any] = [
"SessionEnd": [
Expand Down
3 changes: 3 additions & 0 deletions Tests/CodeIslandTests/QoderWorkSupportTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ final class QoderWorkSupportTests: XCTestCase {
XCTFail("QoderWork hooks are Claude-format JSON")
}
XCTAssertFalse(cli.events.isEmpty)
let permission = try XCTUnwrap(cli.events.first { $0.0 == "PermissionRequest" })
XCTAssertEqual(permission.1, 86400)
XCTAssertFalse(permission.2)
}

func testQoderWorkSourceNormalization() {
Expand Down