Skip to content

Commit 69c3d96

Browse files
committed
fix: address review comments in CMakeLists.txt
- Remove redundant Chinese comment '# 非 Debug 模式下添加 -O3' (keep English only) - Fix full-width comma (U+FF0C) to ASCII comma in RELRO note comment - Remove target_link_options(CGE PRIVATE -fPIE -fPIC -pie): these flags are inappropriate/redundant for a SHARED library; CMake handles -fPIC automatically
1 parent abc8f37 commit 69c3d96

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

library/src/main/jni/CMakeLists.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,11 @@ endif()
8080

8181
target_compile_definitions(CGE PUBLIC ANDROID_NDK=1 CGE_LOG_TAG=\"libCGE\" CGE_TEXTURE_PREMULTIPLIED=1 _CGE_DISABLE_GLOBALCONTEXT_=1 _CGE_ONLY_FILTERS_=1)
8282
83-
# 非 Debug 模式下添加 -O3
8483
# Add -O3 in non-Debug mode
8584
target_compile_options(CGE PRIVATE $<$<NOT:$<CONFIG:Debug>>:-O3>)
8685
87-
# Note: -Wl,-z,relro,-z,now is intentionally omitted here fixing issue: <https://github.com/wysaid/android-gpuimage-plus/issues/562>
88-
target_link_options(CGE PRIVATE -fPIE -fPIC -pie)
86+
# Note: -Wl,-z,relro,-z,now is intentionally omitted here, fixing issue: <https://github.com/wysaid/android-gpuimage-plus/issues/562>
87+
# Android API 23+ enforces full RELRO by default; no explicit linker hardening flags are needed.
8988
9089
target_link_libraries(CGE PUBLIC
9190
GLESv2

0 commit comments

Comments
 (0)