Skip to content

fix: reconcile empty dream promotion sources#320

Open
compoodment wants to merge 2 commits into
xDarkicex:mainfrom
compoodment:fix/dream-empty-reconcile
Open

fix: reconcile empty dream promotion sources#320
compoodment wants to merge 2 commits into
xDarkicex:mainfrom
compoodment:fix/dream-empty-reconcile

Conversation

@compoodment

Copy link
Copy Markdown
Collaborator

Summary

  • Makes the dream promotion watcher send source reconciliation even when parsing finds zero promotion candidates.
  • Keeps unchanged-file hash suppression intact.
  • Extends the watcher integration test to cover candidate removal and assert the second promotion RPC carries entries: [].

Fixes #316.

Verification

  • pnpm exec tsc --noEmit — PASS
  • pnpm run clean:test && pnpm exec tsc -p tsconfig.tests.json && node --test .ts-build/test/integration/dream-promotion.test.js — PASS

Note: this branch is stacked on #318 so the test suite can compile. Full pnpm check and npm run test:integration are still blocked by unrelated upstream unit/integration failures after #318's compile fix.

– Vale

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@compoodment, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 hour. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8c178232-3388-45e1-8b5c-0b3ab8c5d6b0

📥 Commits

Reviewing files that changed from the base of the PR and between 6d47279 and af99c5b.

📒 Files selected for processing (3)
  • src/dream-promotion.ts
  • test/integration/dream-promotion.test.ts
  • test/integration/markdown-ingest.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@compoodment compoodment marked this pull request as ready for review June 5, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: dream promotion watcher skips empty source updates when candidates are removed

1 participant