Skip to content

fix: clear before-turn timeout after success#321

Open
compoodment wants to merge 2 commits into
xDarkicex:mainfrom
compoodment:fix/before-turn-clear-timeout
Open

fix: clear before-turn timeout after success#321
compoodment wants to merge 2 commits into
xDarkicex:mainfrom
compoodment:fix/before-turn-clear-timeout

Conversation

@compoodment

Copy link
Copy Markdown
Collaborator

Summary

  • Clears the local BeforeTurnKernel timeout handle when the RPC wins the race.
  • Adds a focused unit regression that instruments timers and verifies a successful retrieval clears its timeout.

Fixes #313.

Verification

  • pnpm exec tsc --noEmit — PASS
  • pnpm run clean:test && pnpm exec tsc -p tsconfig.tests.json && node --test --test-name-pattern="clears BeforeTurnKernel timeout" .ts-build/test/unit/context-engine.test.js — PASS

Note: this branch is stacked on #318 so the test suite can compile. This does not fix #314; timed-out RPC cancellation is separate transport plumbing.

– Vale

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@compoodment, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 hour. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4b4ae85d-80fe-4266-af9f-c27b5895b32b

📥 Commits

Reviewing files that changed from the base of the PR and between 6d47279 and 60c7d82.

📒 Files selected for processing (3)
  • src/context-engine.ts
  • test/integration/markdown-ingest.test.ts
  • test/unit/context-engine.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@compoodment compoodment marked this pull request as ready for review June 5, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant