Skip to content

Commit 284591d

Browse files
committed
fixing the build against windows
1 parent 81c1fd7 commit 284591d

6 files changed

Lines changed: 13 additions & 6 deletions

File tree

.github/workflows/linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: install NPM dependencies and build native binary
3131
run: yarn
3232
- name: remove native built artifact before publishing
33-
run: rm native/artifacts.json && rm -rf native/target
33+
run: npm run clear-artifact
3434
- name: Package native binary and upload to github
3535
run: npm run upload-binary
3636
env:

.github/workflows/macos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
- name: install NPM dependencies and build native binary
3333
run: yarn
3434
- name: remove native built artifact before publishing
35-
run: rm native/artifacts.json && rm -rf native/target
35+
run: npm run clear-artifact
3636
- name: Package native binary and upload to github
3737
run: npm run upload-binary
3838
env:

.github/workflows/publish.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@ on:
99
- v*
1010

1111
jobs:
12-
build:
13-
12+
publish:
1413
runs-on: ubuntu-latest
15-
1614
steps:
1715
- uses: actions/checkout@v2
1816
- name: Use Node.js 12.x

.github/workflows/windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: install NPM dependencies and build native binary
3131
run: yarn
3232
- name: remove native built artifact before publishing
33-
run: rm native/artifacts.json && rm -rf native/target
33+
run: npm run clear-artifact
3434
- name: Package native binary and upload to github
3535
run: npm run upload-binary
3636
env:

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"node-pre-gyp": "node-pre-gyp",
3434
"build": "neon build",
3535
"package": "npm run node-pre-gyp -- package",
36+
"clear-artifact": "rimraf native/target && rimraf native/artifacts.json",
3637
"upload-binary": "npm run package && node-pre-gyp-github publish"
3738
},
3839
"dependencies": {
@@ -50,6 +51,7 @@
5051
"neon-cli": "^0.4.0",
5152
"node-pre-gyp-github": "^1.4.3",
5253
"prettier": "^2.0.5",
54+
"rimraf": "^3.0.2",
5355
"ts-node": "^8.10.1",
5456
"typescript": "^3.8.3"
5557
},

yarn.lock

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1849,6 +1849,13 @@ rimraf@^2.6.1:
18491849
dependencies:
18501850
glob "^7.1.3"
18511851

1852+
rimraf@^3.0.2:
1853+
version "3.0.2"
1854+
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-3.0.2.tgz#f1a5402ba6220ad52cc1282bac1ae3aa49fd061a"
1855+
integrity sha512-JZkJMZkAGFFPP2YqXZXPbMlMBgsxzE8ILs4lMIX/2o0L9UBw9O/Y3o6wFw/i9YLapcUJWwqbi3kdxIPdC62TIA==
1856+
dependencies:
1857+
glob "^7.1.3"
1858+
18521859
rsvp@^3.5.0:
18531860
version "3.6.2"
18541861
resolved "https://registry.yarnpkg.com/rsvp/-/rsvp-3.6.2.tgz#2e96491599a96cde1b515d5674a8f7a91452926a"

0 commit comments

Comments
 (0)