Merge pull request #27 from xanthous-tech/facet-bugs

Facet bugs

Author: osmanmesutozcan

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xanthous/dgraph-orm",
-  "version": "0.2.0-alpha5",
+  "version": "0.2.0-alpha9",
   "description": "dgraph ORM in TypeScript",
   "main": "dist/index.js",
   "author": "Xanthous Tech Developers <hi@x-tech.io>",
@@ -21,6 +21,7 @@
     "build": "tsc -p tsconfig.build.json",
     "postinstall": "npm run clean && npm run build",
     "prestart": "npm run postinstall",
+    "prepublish": "npm run test && npm run postinstall",
     "lint": "eslint ./src --ext .ts",
     "lint:fix": "eslint --fix",
     "format": "prettier --write",

src/transaction/transaction.ts

@@ -256,7 +256,13 @@ export class Transaction<T extends Object, V> implements ITransaction<T> {
         facetDataIndices.forEach(idx => {
           const plain = facets.reduce<IObjectLiteral>((acc, f) => {
             const facetPropertyName = `${name}|${f.args.propertyName}`;
-            const facetValue = Private.accessUnsafe(value._owner, facetPropertyName)[idx];
+            const facetDataMap = Private.accessUnsafe(value._owner, facetPropertyName);
+
+            if (!facetDataMap) {
+              return acc;
+            }
+
+            const facetValue = facetDataMap[idx];
 
             if (facetValue) {
               acc[f.args.propertyName] = facetValue;

tests/mutation.spec.ts

@@ -101,6 +101,9 @@ describe('Mutation handling', () => {
     class PersonKnows {
       @Facet()
       familiarity: number;
+
+      @Facet()
+      years: number;
     }
 
     @Node()
@@ -120,6 +123,7 @@ describe('Mutation handling', () => {
         uid: '0x1',
         'Person.name': 'John',
         'Person.friends|familiarity': { '0': 999 },
+        'Person.friends|years': { '0': 3 },
         'Person.friends': [
           {
             uid: '0x2',
@@ -152,7 +156,7 @@ describe('Mutation handling', () => {
       `<0x3> <Person.name> "New Kamil"^^<xs:string> .
 <0x2> <Person.name> "New Jane"^^<xs:string> .
 <0x1> <Person.name> "New John"^^<xs:string> .
-<0x1> <Person.friends> <0x2> (familiarity=666) .
+<0x1> <Person.friends> <0x2> (familiarity=666,years=3) .
 `
     );
   });