Skip to content

Commit 0baa116

Browse files
authored
CP-311125 unhide AD cache pool parameters in XE CLI (#6898)
External authentication using Active Directory can use a cache to improve performance. The corresponding fields on the pool object so far were hidden. This patch makes them visible, and as a consequence more easily accessible from the CLI and its autocompletion.
2 parents 8c426d2 + 67b740d commit 0baa116

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

ocaml/idl/datamodel_pool.ml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1516,7 +1516,7 @@ let set_ext_auth_cache_enabled =
15161516
, "Specifies whether caching is enabled for external authentication"
15171517
)
15181518
]
1519-
~hide_from_docs:true ~allowed_roles:_R_POOL_OP ()
1519+
~hide_from_docs:false ~allowed_roles:_R_POOL_OP ()
15201520

15211521
let set_ext_auth_cache_size =
15221522
call ~name:"set_ext_auth_cache_size" ~lifecycle:[]
@@ -1525,7 +1525,7 @@ let set_ext_auth_cache_size =
15251525
(Ref _pool, "self", "The pool")
15261526
; (Int, "value", "The capacity of the external authentication cache")
15271527
]
1528-
~hide_from_docs:true ~allowed_roles:_R_POOL_OP ()
1528+
~hide_from_docs:false ~allowed_roles:_R_POOL_OP ()
15291529

15301530
let set_ext_auth_cache_expiry =
15311531
call ~name:"set_ext_auth_cache_expiry" ~lifecycle:[]
@@ -1538,7 +1538,7 @@ let set_ext_auth_cache_expiry =
15381538
seconds - 300 seconds, i.e. 5 minutes, is the default value)"
15391539
)
15401540
]
1541-
~hide_from_docs:true ~allowed_roles:_R_POOL_OP ()
1541+
~hide_from_docs:false ~allowed_roles:_R_POOL_OP ()
15421542

15431543
let pool_guest_secureboot_readiness =
15441544
Enum

ocaml/xapi-cli-server/records.ml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1520,7 +1520,7 @@ let pool_record rpc session_id pool =
15201520
~get:(fun () -> get_from_map (x ()).API.pool_recommendations)
15211521
~get_map:(fun () -> (x ()).API.pool_recommendations)
15221522
()
1523-
; make_field ~name:"ext-auth-cache-enabled" ~hidden:true
1523+
; make_field ~name:"ext-auth-cache-enabled" ~hidden:false
15241524
~get:(fun () ->
15251525
(x ()).API.pool_ext_auth_cache_enabled |> string_of_bool
15261526
)
@@ -1529,14 +1529,14 @@ let pool_record rpc session_id pool =
15291529
~value:(bool_of_string v)
15301530
)
15311531
()
1532-
; make_field ~name:"ext-auth-cache-size" ~hidden:true
1532+
; make_field ~name:"ext-auth-cache-size" ~hidden:false
15331533
~get:(fun () -> (x ()).API.pool_ext_auth_cache_size |> Int64.to_string)
15341534
~set:(fun v ->
15351535
Client.Pool.set_ext_auth_cache_size ~rpc ~session_id ~self:pool
15361536
~value:(Int64.of_string v)
15371537
)
15381538
()
1539-
; make_field ~name:"ext-auth-cache-expiry" ~hidden:true
1539+
; make_field ~name:"ext-auth-cache-expiry" ~hidden:false
15401540
~get:(fun () ->
15411541
(x ()).API.pool_ext_auth_cache_expiry |> Int64.to_string
15421542
)

0 commit comments

Comments
 (0)