CA-423064: Also check group upgrade when determining updates available

Signed-off-by: Alex Brett <alex.brett@citrix.com>

Author: alexbrett

ocaml/xapi/pkg_mgr.ml

@@ -37,6 +37,9 @@ module type S = sig
 
   val get_updates_from_upgrade_dry_run : repositories:string list -> cmd_line
 
+  val get_updates_from_group_upgrade_dry_run :
+    repositories:string list -> cmd_line
+
   val is_obsoleted : pkg_name:string -> repositories:string list -> cmd_line
 
   val repoquery_updates : repositories:string list -> cmd_line
@@ -73,6 +76,8 @@ module type Args = sig
 
   val get_updates_from_upgrade_dry_run : string list -> string list
 
+  val get_updates_from_group_upgrade_dry_run : string list -> string list
+
   val is_obsoleted : string -> string list -> string list
 
   val repoquery_updates : string list -> string list
@@ -129,6 +134,16 @@ module Common_args = struct
     ; "upgrade"
     ]
 
+  let get_updates_from_group_upgrade_dry_run repositories =
+    [
+      "--disablerepo=*"
+    ; Printf.sprintf "--enablerepo=%s" (String.concat "," repositories)
+    ; "--assumeno"
+    ; "group"
+    ; "upgrade"
+    ; "*"
+    ]
+
   let repoquery repositories =
     [
       "--disablerepo=*"
@@ -193,6 +208,10 @@ module Yum_args : Args = struct
   let get_updates_from_upgrade_dry_run repositories =
     ["--quiet"] @ Common_args.get_updates_from_upgrade_dry_run repositories
 
+  let get_updates_from_group_upgrade_dry_run repositories =
+    ["--quiet"]
+    @ Common_args.get_updates_from_group_upgrade_dry_run repositories
+
   let is_obsoleted pkg_name repositories =
     ["--all"] @ Common_args.is_obsoleted pkg_name repositories @ ["--plugins"]
 
@@ -297,6 +316,12 @@ module Cmd_line (M : Args) : S = struct
   let get_updates_from_upgrade_dry_run ~repositories =
     {cmd= M.pkg_cmd; params= M.get_updates_from_upgrade_dry_run repositories}
 
+  let get_updates_from_group_upgrade_dry_run ~repositories =
+    {
+      cmd= M.pkg_cmd
+    ; params= M.get_updates_from_group_upgrade_dry_run repositories
+    }
+
   let is_obsoleted ~pkg_name ~repositories =
     {cmd= M.repoquery_cmd; params= M.is_obsoleted pkg_name repositories}
 

ocaml/xapi/pkg_mgr.mli

@@ -41,6 +41,10 @@ module type S = sig
   val get_updates_from_upgrade_dry_run : repositories:string list -> cmd_line
   (** Command line and arguments to dry run an upgrade, with repositories enabled *)
 
+  val get_updates_from_group_upgrade_dry_run :
+    repositories:string list -> cmd_line
+  (** Command line and arguments to dry run a group upgrade, with repositories enabled *)
+
   val is_obsoleted : pkg_name:string -> repositories:string list -> cmd_line
   (** Command line and arguments to check whether a package is obsoleted by any other
    * package in given repositories *)

ocaml/xapi/repository.ml

@@ -558,6 +558,20 @@ let get_host_updates_in_json ~__context ~installed =
         let latest_updates' =
           get_updates_from_yum_upgrade_dry_run repositories
         in
+        let latest_updates_group' =
+          get_updates_from_yum_group_upgrade_dry_run repositories
+        in
+        let latest_updates_combined' =
+          match (latest_updates', latest_updates_group') with
+          | Some pkgs', Some group_pkgs' ->
+              Some (List.sort_uniq compare (pkgs' @ group_pkgs'))
+          | Some pkgs', None ->
+              Some pkgs'
+          | None, Some group_pkgs' ->
+              Some group_pkgs'
+          | None, None ->
+              None
+        in
         let latest_updates'' = get_updates_from_repoquery repositories in
         (* To ensure the updating function will not strand, use redundant
          * functions to get the update/installation list.
@@ -569,7 +583,7 @@ let get_host_updates_in_json ~__context ~installed =
         let fail_on_error = Xapi_fist.fail_on_error_in_yum_upgrade_dry_run () in
         let latest_updates =
           get_latest_updates_from_redundancy ~fail_on_error
-            ~pkgs:latest_updates' ~fallback_pkgs:latest_updates''
+            ~pkgs:latest_updates_combined' ~fallback_pkgs:latest_updates''
         in
         List.iter (fun r -> clean_yum_cache r) repositories ;
         let latest_updates_in_json =

ocaml/xapi/repository_helpers.ml

@@ -771,8 +771,10 @@ module YumUpgradeOutput = struct
     | false -> (
         take_till is_eol <* end_of_line >>= function
         | ( "Installing:"
+          | "Installing group/module packages:"
           | "Updating:"
           | "Upgrading:"
+          | "Upgrading groups:"
           | "Removing:"
           | "Reinstalling:"
           | "Downgrading:"
@@ -890,6 +892,7 @@ module YumUpgradeOutput = struct
         |> List.filter (fun (section, _) ->
             match section with
             | "Installing:"
+            | "Installing group/module packages:"
             | "Updating:"
             | "Upgrading:"
             | "Installing for dependencies:"
@@ -958,6 +961,31 @@ let get_updates_from_yum_upgrade_dry_run repositories =
       error "%s" (ExnHelper.string_of_exn e) ;
       None
 
+let get_updates_from_yum_group_upgrade_dry_run repositories =
+  let Pkg_mgr.{cmd; params} =
+    Pkgs.get_updates_from_group_upgrade_dry_run ~repositories
+  in
+  match Forkhelpers.execute_command_get_output cmd params with
+  | _, _ ->
+      Some []
+  | exception Forkhelpers.Spawn_internal_error (stderr, stdout, Unix.WEXITED 1)
+    -> (
+      (*Yum put the details to stderr while dnf to stdout*)
+      (match Pkgs.manager with Yum -> stderr | Dnf -> stdout)
+      |> YumUpgradeOutput.parse_output_of_dry_run
+      |> function
+      | Ok (pkgs, Some txn_file) ->
+          Unixext.unlink_safe txn_file ;
+          Some pkgs
+      | Ok (pkgs, None) ->
+          Some pkgs
+      | Error msg ->
+          error "%s" msg ; None
+    )
+  | exception e ->
+      error "%s" (ExnHelper.string_of_exn e) ;
+      None
+
 let get_latest_updates_from_redundancy ~fail_on_error ~pkgs ~fallback_pkgs =
   let err = "Failed to parse output of 'yum upgrade (dry run)' correctly" in
   let get_latest_updates_from_redundancy' ~fail_on_error ~pkgs ~fallback_pkgs =