CA-424916 don't exit thread/loop on events error

In XSI-2169 an INVALID_VALUE exception leads to the restart of the
events thread - without fixing anything. So don't re-raise the exception
after logging it.

Signed-off-by: Christian Lindig <christian.lindig@citrix.com>

Author: lindig

ocaml/xapi/xapi_xenops.ml

@@ -3446,19 +3446,17 @@ let events_from_xapi () =
                           if resident_here then
                             Xenopsd_metadata.update ~__context ~self:vm
                             |> ignore
-                        with e ->
-                          if not (Db.is_valid_ref __context vm) then
+                        with
+                        | e when not (Db.is_valid_ref __context vm) ->
                             debug
                               "VM %s has been removed: event on it will be \
-                               ignored"
-                              (Ref.string_of vm)
-                          else (
+                               ignored: %S"
+                              (Ref.string_of vm) (Printexc.to_string e)
+                        | e ->
                             error
                               "Caught %s while processing XenAPI event for VM \
                                %s"
-                              (Printexc.to_string e) (Ref.string_of vm) ;
-                            raise e
-                          )
+                              (Printexc.to_string e) (Ref.string_of vm)
                       )
                     | {ty= "host"; reference= t; _} when t = localhost' ->
                         debug